Re: Failing windows tests for level-set

[Daniel Kraft]

Hi!

On 2015-04-13 07:40, Oliver Heimlich wrote:
> On 13.04.2015 07:29, Daniel Kraft wrote:
>> Hi all!
>>
>> My package level-set shows a few failing tests in the recently posted
>> Windows logs.  According to the logs [1], at least the "main" failures
>> seem to be the tests for "ls_copy_sign".
>>
>>    [1] http://octave.ln0.de/octave-4.0rc3-win7x64/level-set-0.2.0-fntests.log
>>
>> This function is in the "private" directory of the package and only used
>> internally.  It seems to me that the error is produced because the
>> testing is done in such a way that "private" functions are not on the
>> path (but I can not test myself on Windows).  My package has a
>> "testAll.m" script which runs all tests, with proper addpath of the
>> private directory before testing ls_copy_sign.
> 
> I can try to re-evaluate the tests with fixed paths and/or with the 
> testAll script. AFAIK, tests may only access public functions as well as 
> shared test functions [1]. So it would be a good idea to fix the tests.

In this case, the point is that I actually want to test the private
function itself.  (Of course, it is also indirectly tested by the
functions which use it -- but I would like to directly test its
functionality as well.)

The tests are part of the private function, by the way.  So running the
tests of public functions should all work fine without messing with the
paths -- so the failures only should show up if you try to run the tests
of the private function itself (which your script presumably does).

Is this considered wrong?  If so, how should I "fix" the package so that
I can actually have tests on the private function itself (which I want
to have)?

Yours,
Daniel

-- 
http://www.domob.eu/
OpenPGP: 1142 850E 6DFF 65BA 63D6  88A8 B249 2AC4 A733 0737
Namecoin: id/domob -> https://nameid.org/?name=domob
--
Done:  Arc-Bar-Cav-Hea-Kni-Ran-Rog-Sam-Tou-Val-Wiz
To go: Mon-Pri

signature.asc
Description: OpenPGP digital signature