[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: input validation in C++ internal functions
From: |
Juan Pablo Carbajal |
Subject: |
Re: input validation in C++ internal functions |
Date: |
Thu, 22 May 2014 12:41:08 +0200 |
On Thu, May 22, 2014 at 10:10 AM, Andreas Weber <address@hidden> wrote:
> Am 05.05.2014 19:24, schrieb Jordi GutiƩrrez Hermoso:
>> On Mon, 2014-05-05 at 16:39 +0100, Michael D. Godfrey wrote:
>>> On 05/05/2014 07:47 AM, Andreas Weber wrote:
>>>> In my humble optinion no function should segfault when accessible from
>>>> the octave interpreter.
>>> I am pretty sure that Jordi agrees with this, and it s a long-standing
>>> principle that Octave should never seg fault.
>>
>> Yeah, it's a bug, although I consider it a minor one, since it's in
>> internal functions.
>>
>> My complaint at the time was that almost none of the internal C++
>> functions do any argument-checking. I'm not against this sort of
>> patch, but I am against cluttering every internal C++ function with
>> argument-checking boilerplate code. Andy's patch in question at the
>> moment looks reasonable to me, but it's a stopgap around a larger
>> problem.
>
> Pushed to stable
> http://hg.savannah.gnu.org/hgweb/octave/rev/5e99fd6ea758 after
> discussion in IRC. -- Andy
>
>
Is it possible to add a error_id in the error message?
I suggest
error ("Octave:invalid-input-arg", "__calc_dimensions__: expecting
graphics handle as only argument");
ids and their description can be retrieved using error_ids in the octave prompt
- input validation in C++ internal functions, Andreas Weber, 2014/05/05
- Re: input validation in C++ internal functions, Michael D. Godfrey, 2014/05/05
- Re: input validation in C++ internal functions, Jordi GutiƩrrez Hermoso, 2014/05/05
- Re: input validation in C++ internal functions, Andreas Weber, 2014/05/22
- Re: input validation in C++ internal functions,
Juan Pablo Carbajal <=
- Re: input validation in C++ internal functions, Andreas Weber, 2014/05/23
- Re: input validation in C++ internal functions, Juan Pablo Carbajal, 2014/05/23
- Re: input validation in C++ internal functions, John W. Eaton, 2014/05/23
- Re: input validation in C++ internal functions, Juan Pablo Carbajal, 2014/05/23