Re: clang errors building miscellaneous

[Jordi Gutiérrez Hermoso]

On Sat, 2014-05-17 at 20:50 +0000, Montgomery-Smith, Stephen wrote:
> And I have never used Mercurial patches.

How did you create these diffs? With hg, you would create them like
so:

   0) Install hg and put the following or similar in your ~/.hgrc:

       [ui]
       username = Stephen Montgomery-Smith <address@hidden>

       [extensions]
       color=
       progress=
       pager=

       [pager]
       pager = LESS='FSRX' less
       attend = 

   1) clone the repos you want to patch:

       hg clone http://hg.code.sf.net/p/octave/miscellaneous

   2) Modify the code appropriately (don't leave dead commented-out
      code in there).

   3) Verify the commit (patch) you're about to create.

       hg status
       hg diff

   4) Commit it. This should open a text editor in which you can write
      your commit message.

       hg commit      ## or `hg ci` for short
   
   5) Export the commit

       hg export -r . -o stephens-patch-for-fixing-octave.diff

   6) Put the stephens-patch-etc.diff on our patch tracker:

       https://savannah.gnu.org/patch/?func=additem&group=octave

I know this may look like a lot of work now, but that's because I put
a lot of detail into it. The idea is that it will be a one-time cost
for you to acquire this workflow. My hope is that this cost will pay
off in the long term and we manage to attract you as a contributor.

> So first I want to see some discussion about whether vectors
> could be used instead, and other general comments on my code.

Uhh... wait... partarray.cc has been removed:

    $ hg log -r 'max(file("**/partarray.cc"))'
    changeset:   369:8dcccc6dc269
    user:        carandraug
    date:        Tue Feb 19 17:23:56 2013 +0000
    summary:     miscellaneous: remove functions deprecated on v1.1.0 (released 
on 2012-03-24)

Indeed:

    http://sourceforge.net/p/octave/miscellaneous/ci/8dcccc6dc269

This would have been obvious if we had started working from the hg
repo to begin with. So there's no need for this particular patch.
Instead, I suppose we should just make a new release of the
miscellaneous package.

Oh well, for future reference, I decided to still send what I wrote
above about how to use hg.

- Jordi G. H.

P.S. A while ago I read your comments on Math Overflow over Otelbaev's
proposed proof, thanks for the summary. I enjoyed that.