octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: 3.8.0-rc1 make check failures on Fedora rawhide


From: John W. Eaton
Subject: Re: 3.8.0-rc1 make check failures on Fedora rawhide
Date: Tue, 10 Dec 2013 23:34:21 -0500
User-agent: Mozilla/5.0 (X11; Linux i686; rv:10.0.11) Gecko/20121123 Icedove/10.0.11

On 12/09/2013 06:56 PM, Rik wrote:
On 12/09/2013 03:39 PM, Jordi GutiƩrrez Hermoso wrote:
On Mon, 2013-12-09 at 15:23 -0700, Orion Poplawski wrote:
  >  On 12/09/2013 09:53 AM, Rik wrote:
On 12/08/2013 10:00 AM, address@hidden wrote:
Most of these are coming from the lack of DISPLAY. Shouldn't they
be skipped instead?
The test suite finds that you have FLTK and proceeds to try and
switch the graphic toolkit over to FLTK which then fails because
no DISPLAY is set.
I'll just mention that this will be a pain for packagers. Without
jumping through a lot of hoops, there is no X environment on the
Fedora builders.
More generally than for packaging, Octave should fall back to gnuplot
if there is no X server. Should this patch go on the stable branch? I
can prepare it.
Octave is already falling back to gnuplot so that behavior is okay.  The
problem is that the %!test is trying to switch the graphics toolkit to FLTK
and doesn't check if an error has occurred while doing so.

I'd like to avoid unnecessary failures in the tests on systems without a display.

What is the best way to do that? Fix "testif HAVE_FLTK" to only succeed if FLTK is both available and can be used? Allow the test to pass (or fail?) if the display is not available? Something else?

jwe


reply via email to

[Prev in Thread] Current Thread [Next in Thread]