[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: PATCH: octave-image, regionprops "WeightedCentroid" fails with 1 ele
From: |
Andreas Weber |
Subject: |
Re: PATCH: octave-image, regionprops "WeightedCentroid" fails with 1 element regions |
Date: |
Sun, 29 Sep 2013 07:56:40 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130827 Icedove/17.0.8 |
Am 28.09.2013 17:19, schrieb Carnë Draug:
> On 13 September 2013 08:36, Andreas Weber
> <address@hidden> wrote:
>>
>> [...]
>>
>> diff -r ff3db65873b9 inst/regionprops.m
>> --- a/inst/regionprops.m Fri Sep 13 08:30:30 2013 +0200
>> +++ b/inst/regionprops.m Fri Sep 13 09:32:41 2013 +0200
>> @@ -276,7 +276,7 @@
>> C = all_coords (L == k, true, true);
>> vals = I (L == k) (:);
>> vals /= sum (vals);
>> - retval (k).WeightedCentroid = [dot(C, repmat(vals, 1,
>> columns(C)))];
>> + retval (k).WeightedCentroid = [dot(C, repmat(vals, 1,
>> columns(C)), 1)];
>> endfor
>>
>> case "meanintensity"
>>
>>
>> I'll push it tomorrow if there is no veto.
>
> Just a remind that you never got to push this change yet.
>
> Carnë
Hi Carnë, thank you very much for the reminder.
I made this change together with 6db5e3c6759b2e580f8059aef3b
http://sourceforge.net/p/octave/image/ci/6db5e3c6759b2e580f8059aef3b16739482b9dee/tree/inst/regionprops.m?diff=ed986360b69a82a912b486e79e1b099e753c53a2
and I'm sorry that I forgot to add the fixed "single element problem" to
the commit message.
greetings, Andy