Re: strncmp cleanup

[Rik]

On 09/11/2013 07:10 AM, address@hidden wrote:
> Message: 1
> Date: Wed, 11 Sep 2013 13:35:05 +0200
> From: Andreas Weber <address@hidden>
> To: Octave Maintainers List <address@hidden>
> Subject: PATCH: build error from change 3f0ed69d21c6 (strncmp<>strcmp
>       cleanup)
> Message-ID: <address@hidden>
> Content-Type: text/plain; charset="iso-8859-1"
>
> Dear maintainers,
>
> change 3f0ed69d21c6 "Replace unnecessary instances of strncmp with
> strcmp" introduced 2 little bugs:
>
> __go_draw_axes__.m: 646 if (strncmp (obj.facecolor, "none"))
> uigetfile.m: 177: elseif (strcmpi (prop, "multiselect", 11))
>
> This leads to "error: Invalid call to strncmp." when building
> current default 3611ebb0ad88 and also breaks "hist".
>
> fix 2 strcmp<->strncmp issues from 3f0ed69d21c6
> * __go_draw_axes__.m: replaced strncmp with strcmp
> * scripts/plot/uigetfile.m: removed length specifier from strcmpi
9/11/13

Andreas,

Thanks for that.  It was a large changeset and I made two typos.  It points
out again why we need full test coverage of Octave because I had run 'make
check' and didn't find anything.

Cheers,
Rik

p.s. I've applied both of your patches today.