Re: do_load differs in load-save.cc and load-save.h

[Jordi Gutiérrez Hermoso]

2011/10/4 c. <address@hidden>:
>
> On 5 Oct 2011, at 00:34, Jordi Gutiérrez Hermoso wrote:
>
>> Uhm... what?
>>
>>    
>> http://hg.savannah.gnu.org/hgweb/octave/file/4916b436d0bb/src/load-save.cc#l330
>>
>> How did you miss it? It's readily greppable. Or am *I* missing something?
>>
>> - Jordi G. H.
>
> Jordi,
>
> Sorry for not being clear enough,
> the two functions look different to me.
>
> in load-save.h the order of the argument types is:
> std::istream&, const std::string&, bool, etc...
>
> while in load-save.cc it is:
> std::istream&, const std::string&, load_save_format, etc...
>
> an input parameter of type bool is missing in the definition or is unneeded 
> in the declaration?
> or is there anoother reason why the two differ?

You're right, it's an error. But do_load is only called internally in
load-save.cc, so there's no reason why its declaration should be
correct. Just push a patch to remove the erroneous declaration from
load-save.h.

- Jordi G. H.