[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: new files: scripts/plot/daspect.m & pbaspect.m
From: |
Ben Abbott |
Subject: |
Re: new files: scripts/plot/daspect.m & pbaspect.m |
Date: |
Thu, 28 Jan 2010 21:16:52 -0500 |
On Jan 28, 2010, at 11:08 AM, Ben Abbott wrote:
> On Jan 27, 2010, at 9:56 AM, Ben Abbott wrote:
>
>> On Wednesday, January 27, 2010, at 09:36AM, "Jaroslav Hajek"
>> <address@hidden> wrote:
>>> On Wed, Jan 27, 2010 at 2:46 PM, Ben Abbott <address@hidden> wrote:
>>>> I'd like to add these two missing Matlab functions. However, I noticed the
>>>> Makefile.in's disappeared since I last added a file to the sources. Will
>>>> the attached do the job?
>>>>
>>>
>>> You should also add the functions to plot/module.mk.
>>>
>>
>> Thanks!
>>
>> Does the attached look correct?
>>
>> Ben
>> <changeset.patch>
>
>
> I've been studying the changelog and changesets to verify my understanding
> for how new m-files are to be added.
>
> If I understand correctly, when adding m-files the new function needs to be
> added to the <dir>_FCN_FILES list in module.mk. However, the changeset below
> does not do that.
>
> http://hg.savannah.gnu.org/hgweb/octave/rev/27777bd27e71
>
> Is my understanding wrong, or should chop.m be added to general_FCN_FILES in
> scripts/general/module.mk?
>
> Ben
I've pushed the changeset adding the new functions; daspect.m and pbaspect.m
http://hg.savannah.gnu.org/hgweb/octave/rev/ce94aaa71a4f
Ben