Re: new build ends with mkfifo related problems in file-ops.cc

[Ben Abbott]

On Friday, January 22, 2010, at 02:31PM, "John W. Eaton" <address@hidden> wrote:
>On 22-Jan-2010, Ben Abbott wrote:
>
>| > file-ops.cc:118: error: no ‘int file_ops::rpl_mkfifo(const std::string&, 
>mode_t)’ member function declared in class ‘file_ops’
>| > file-ops.cc: In member function ‘int file_ops::rpl_mkfifo(const 
>std::string&, mode_t)’:
>| > file-ops.cc:121: error: no matching function for call to 
>‘file_ops::rpl_mkfifo(const std::basic_string<char, std::char_traits<char>, 
>std::allocator<char> >&, mode_t&, std::string&)’
>| > file-ops.cc:118: note: candidates are: int file_ops::rpl_mkfifo(const 
>std::string&, mode_t)
>| > file-ops.cc: At global scope:
>| > file-ops.cc:125: error: prototype for ‘int file_ops::rpl_mkfifo(const 
>std::string&, mode_t, std::string&)’ does not match any in class ‘file_ops’
>| > file-ops.cc:118: error: candidate is: int file_ops::rpl_mkfifo(const 
>std::string&, mode_t)
>| > make[3]: *** [liboctave_la-file-ops.lo] Error 1
>| > make[2]: *** [all] Error 2
>| > make[1]: *** [all-recursive] Error 1
>| > make: *** [all] Error 2
>| > 
>| > Adding  "#include <sys/types.h>" to file-io.cc fixes this for me, but I 
>don't know if this is the right thing to do.
>| 
>| oppps... I meant "#include <sys/stat.h>"
>
>Either way, I don't think it is the right fix.  Notice the
>file_ops::rpl_mkfifo name.  That's not supposed to be redefined here.
>Since it is redefined, it doesn't match what appears in the header.
>
>I think the problem is that statdefs.h is included in file-ops.cc and
>that brings in sys/stat.h, which defines mkfifo to be rpl_mkfifo if
>you are getting the gnulib version of sys/stat.h.
>
>Try removing the #include "statdefs.h" line from file-ops.cc and the
>#include <sys/stat.h> line from file-io.cc that you added.  Does that
>fix the problem?
>
>jwe
>

Yes, liboctave builds now. Thanks!

When run it still crashes due to the problem you've associated with 
prog_args::rpl_getopt().

Ben