Re: 3.0.4 RC6

[Jaroslav Hajek]

2009/3/26 Tatsuro MATSUOKA <address@hidden>:
> Hello
>
> I have tested on mingw (GCC-4.3.3-dw2-TDM).
>
>> There is a failure in "controldemo" (option 3, then option 2, then
>> option 1) which is fixed by the attached patch.
> I have confirmed fix by Rob's patch for control demo
>
>> The bug exposed by "subplot(111); clf; plot([1 2],[3 4])" is gone.
> I have also confirmed and also exdiff.m
>
>  d:\usr\Tatsu\mingwhome\octaves\octave-3.0.4RC6\src\ov-fcn-handle.cc  PASS    
> 2/3    FAIL 1
>  test_string.m .......................................... PASS  130/131  FAIL 
> 1
>
>  PASS   4124
>  FAIL      2
>
>
> The problem of ov-fcn-handle.cc is not corrected
>>>>>> processing 
>>>>>> d:\usr\Tatsu\mingwhome\octaves\octave-3.0.4RC6\src\ov-fcn-handle.cc
>  ***** test
>  a = 2;
>  f = @(x) a + x;
>  g = @(x) 2 * x;
>  h = @log2;
>  f2 = f;
>  g2 = g;
>  h2 = h;
>  nm = tmpnam();
>  unwind_protect
>   save ("-text", nm, "f2", "g2", "h2");
>   clear f2 g2 h2
>   load (nm);
>   assert (f(2),f2(2));
>   assert (g(2),g2(2));
>   assert (g(3),g2(3));
>   unlink (nm);
>   save ("-text", nm, "f2", "g2", "h2");
>  unwind_protect_cleanup
>   unlink (nm);
>  end_unwind_protect
> !!!!! test failed
>
> Please see,
> http://www-old.cae.wisc.edu/pipermail/octave-maintainers/2009-March/011319.html
>
> Hi Benjamin, can you prepare the patch for this problem against RC6?
>

There's no need; the patch was directly applicable, just I obviously
missed it. Just CCing me does not help much, because I got the CC from
mailing list anyway and the message is sorted identically - I can only
notice that gmail may show "me" in the conversation header. Obviously,
bug tracker would do a much better job. I need to be more zealous
about it.


> About test_string.m
>  test_string.m .......................................... PASS  130/131  FAIL 
> 1
>
> Please use the below.
> --- a/ChangeLog Tue Aug 19 16:15:52 2008 -0400
> +++ b/ChangeLog Fri Aug 22 13:37:16 2008 +0900
> @@ -1,3 +1,7 @@
> +2008-08-22  Tatsuro MATSUOKA  <address@hidden>
> +
> +       test/octave.test/string/isprint-1.m in test_string.m for fixed.
> +
>  2008-08-19  Jaroslav Hajek <address@hidden>
>
>        Version 3.0.2 released.
> diff -r 4908e39553b0 test/test_string.m
> --- a/test/test_string.m        Tue Aug 19 16:15:52 2008 -0400
> +++ b/test/test_string.m        Fri Aug 22 13:37:16 2008 +0900
> @@ -532,7 +532,7 @@
>  %! result = zeros (1, 128);
>  %!
>  %! result (33:127) = 1;
> -%! if (ispc () && ! isunix ())
> +%! if (size(findstr (octave_config_info('canonical_host_type'), 'msvc'),2))
>  %!   result(10) = 1;
>  %! endif
>  %!
>

OK applied. Again I have a vague impression that this is not the first
time I see this one. I'll prepare RC7 immediatelly.

regards

-- 
RNDr. Jaroslav Hajek
computing expert & GNU Octave developer
Aeronautical Research and Test Institute (VZLU)
Prague, Czech Republic
url: www.highegg.matfyz.cz