[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: 3.0.4 RC3 (mingw 3.4.5)-2
From: |
Tatsuro MATSUOKA |
Subject: |
Re: 3.0.4 RC3 (mingw 3.4.5)-2 |
Date: |
Tue, 10 Mar 2009 15:54:41 +0900 (JST) |
Hello Benjamin
I have built octave-3.0.4RC5 binaries with your fix-ascii-text-mode-crlf.patch.
Your patch induced additional three failures for the cygwin build.
Perhaps these failure come from
jwe> Otherwise I saw 6 new failures when running make check. Why was this
jwe> line added? Is it needed for systems that have CRLF? If so, why?
in
http://www.nabble.com/Re:-3.0.4-RC3-(mingw-3.4.5)-2-p22428193.html
Regards
Tatsuro
src/ov-fcn-handle.cc ................................... PASS 2/3 FAIL 1
test_prefer.m .......................................... PASS 27/29 FAIL 2
>>>>> processing
>>>>> /cygdrive/d/usr/Tatsu/mingwhome/octaves/octave-3.0.4RC5/src/ov-fcn-handle.cc
***** test
a = 2;
f = @(x) a + x;
g = @(x) 2 * x;
h = @log2;
f2 = f;
g2 = g;
h2 = h;
nm = tmpnam();
unwind_protect
save ("-text", nm, "f2", "g2", "h2");
clear f2 g2 h2
load (nm);
assert (f(2),f2(2));
assert (g(2),g2(2));
assert (g(3),g2(3));
unlink (nm);
save ("-text", nm, "f2", "g2", "h2");
unwind_protect_cleanup
unlink (nm);
end_unwind_protect
!!!!! test failed
error: load: failed to load scalar constant
>>>>> processing test_prefer
***** test
sp = save_precision ();
save_precision (1);
x = pi;
nm = tmpnam();
save("-text",nm,"x");
clear x;
load(nm);
unlink(nm);
assert(x,3);
save_precision (sp);
!!!!! test failed
error: load: failed to extract keyword specifying value type
***** test
sp = save_precision ();
save_precision (5);
x = pi;
nm = tmpnam();
save("-text",nm,"x");
clear x;
load(nm);
unlink(nm);
assert(x,3.1416);
save_precision (sp);
!!!!! test failed
error: load: failed to extract keyword specifying value type
--- "John W. Eaton" wrote:
> On 3-Mar-2009, Benjamin Lindner wrote:
>
> | John W. Eaton wrote:
> | > On 30-Jan-2009, Benjamin Lindner wrote:
> | >
> | > | To work around it in octave we need to rethink octave's way to save
> | > | anonymous function handles in ascii format.
> | > | I have tried something for in the development branch, which allows this
> | > | test to pass, but it means a small but significant change in the format
> | > | of saving anonymous function handles. This breaks backwards
> | > | compatibility, so I'm not really happy about my approach.
> | >
> | > We can open text files for reading in binary mode. It just means that
> | > we have to handle the CRLF, CR, and LF line endings ourselves. We
> | > already do that (more or less) for .m files. But it would maybe be a
> | > good idea to come up with a unified way of doing it for all of Octave.
> | >
> |
> | I have put some thought into this problem and have changed the behaviour
> | of reading ascii mode data by doing the following
> | *) files get always opened in binary mode when loading data (saving to
> | ascii is still done in text mode)
> | *) walked through the load_ascii( ) method of the various octave_value
> | derived classes and moved all newline/cr/lf related code into common
> | functions
> | *) created ls-ascii-helper.h and ls-ascii-helper.cc and stored the
> | common functions there
> |
> | With this, I get rid of the failing test in ov-fcn-handle.cc on mingw. I
> | have no additional failed tests. Saving and loading in "-text" format
> | seems to work, I have not encountered problems yet.
> |
> | I don't have access to matlab, so I could not check what happens with
> | data files in matlab's text format. I'd appreciate cross-checks.
>
> I applied this patch with some style changes. I also had to remove
> this part of the patch:
>
> | diff -r 97991a9e7a18 -r 1315d5c25fa9 src/ls-oct-ascii.cc
> | --- a/src/ls-oct-ascii.cc Tue Mar 03 19:28:03 2009 +0100
> | +++ b/src/ls-oct-ascii.cc Tue Mar 03 10:09:56 2009 +0100
> | @@ -118,14 +119,15 @@
> | }
> |
> | retval = value.str ();
> | + skip_until_newline (is, false);
> | break;
> | }
> | else if (next_only)
>
> Otherwise I saw 6 new failures when running make check. Why was this
> line added? Is it needed for systems that have CRLF? If so, why?
>
> Thanks,
>
> jwe
>
--------------------------------------
Power up the Internet with Yahoo! Toolbar.
http://pr.mail.yahoo.co.jp/toolbar/
- Re: 3.0.4 RC3 (mingw 3.4.5)-2, Benjamin Lindner, 2009/03/03
- Re: 3.0.4 RC3 (mingw 3.4.5)-2, Tatsuro MATSUOKA, 2009/03/04
- Re: 3.0.4 RC3 (mingw 3.4.5)-2, Tatsuro MATSUOKA, 2009/03/04
- Re: 3.0.4 RC3 (mingw 3.4.5)-2, Tatsuro MATSUOKA, 2009/03/05
- Re: 3.0.4 RC3 (mingw 3.4.5)-2, Tatsuro MATSUOKA, 2009/03/05
- Re: 3.0.4 RC3 (mingw 3.4.5)-2, Benjamin Lindner, 2009/03/08
- Re: 3.0.4 RC3 (mingw 3.4.5)-2, Tatsuro MATSUOKA, 2009/03/09
- Re: 3.0.4 RC3 (mingw 3.4.5)-2, Tatsuro MATSUOKA, 2009/03/09
Re: 3.0.4 RC3 (mingw 3.4.5)-2, John W. Eaton, 2009/03/10