Re: surf problem

[Daniel J Sebald]

Ben Abbott wrote:
> On Oct 19, 2008, at 4:04 AM, Daniel J Sebald wrote:
>
> > Well, that change certainly seems to make cylinder() look correct.   
> > I'll pay attention to see that there isn't something strange like  
> > axes swapping or reversing.
>
>
> I had noticed record length for lines 465-467 respected "rows"
>
>           data{data_idx} = [xdat, ydat]';
>           usingclause{data_idx} = sprintf ("record=%d using ($1):($2)  
> axes %s%s",
>                           rows(xdat), xaxisloc_using, yaxisloc_using);
>
> Line 491-492, 574-575, also refer to "rows"
>
>        xcol = obj.xdata(:,i);
>        ycol = obj.ydata(:,i);
> [...]
>            data{data_idx} = [xcol, ycol]';
>            usingclause{data_idx} = sprintf ("record=%d using 
> ($1):($2)",  numel (xcol));
>
> Lines 798-799, 821 began with columns and then rows.
>
>         xlen = columns (zdat);
>         ylen = rows (zdat);
> [...]
>         usingclause{data_idx} = sprintf ("record=%dx%d using ($1):($2): 
> ($3):($4)", xlen, ylen);
>
> I inferred that the record lengths should be rows(zdat),  columns(zdat), 
> so I flipped the order of ylen and xlen to ...
>
>         usingclause{data_idx} = sprintf ("record=%dx%d using ($1):($2): 
> ($3):($4)", ylen, xlen);

Oh, I see.  It may be more consistent to define:

xlen = rows (zdat);
ylen = columns (zdat);


> Regarding the hold on/off for surfnorm, I've also submitted a  changeset 
> on another thread, I don't see it in Nabble, but it is  addressed to the 
> maintainers list.
>
> If  you are substribed to the maintainers list, can you verify that I  
> posted a few changeset yesterday evening?

I don't see any changesets posted...  and I forgot to send mine (attached) to 
the list.

Dan

--- /usr/local/share/octave/3.0.0+/m/plot/surfnorm.m    2008-01-30 
21:13:54.000000000 -0600
+++ surfnorm.m  2008-10-19 02:49:28.366799217 -0500
@@ -111,6 +111,7 @@
   if (nargout == 0)
     oldh = gca ();
     unwind_protect
+      hold_state = get (h, "nextplot");
       axes (h);
       newplot ();
       surf (x, y, z, varargin{ioff:end});
@@ -119,6 +120,7 @@
             [y(:)'; y(:).' + ny(:).' ; NaN(size(y(:).'))](:),
             [z(:)'; z(:).' + nz(:).' ; NaN(size(z(:).'))](:), 
             varargin{ioff:end});
+      set (h, "nextplot", hold_state);
     unwind_protect_cleanup
       axes (oldh);
     end_unwind_protect