[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Changeset] isa function with float and numeric arguments
From: |
John W. Eaton |
Subject: |
Re: [Changeset] isa function with float and numeric arguments |
Date: |
Mon, 12 May 2008 22:55:07 -0500 |
On 12-May-2008, Bill Denney wrote:
| David Bateman wrote:
| > David Bateman wrote:
| >
| >> The isa function should allow the "float" and "numeric" arguments. The
| >> attached patch adds this.
| >>
| >> D.
| > Please use this version instead.
| >
| > D.
| >
| Wouldn't this be easier to read (and marginally faster) if written as:
|
| if (strcmp (cname, "float"))
| retval = any (strcmp (class (x), {"double" "single"}));
| elseif (strcmp (cname, "fnumeric"))
| classes = {"double" "single" "uint8" "uint16" "uint32" "uint64" "int8"
"int16" "int32" "int64"};
| retval = any (strcmp (class (x), classes));
| else
| retval = strcmp (class (x), cname);
| endif
I made this change, and used persistent variables for the cell arrays
to avoid the need for reinitializing them on each call.
Thanks,
jwe