Re: isascii/toascii with MSVC

[Michael Goffioul]

On Mon, Feb 25, 2008 at 11:05 AM, John W. Eaton <address@hidden> wrote:
> I think I'd prefer to have the octave_value function names be the same
> as they are in the scripting language,

I agree, it's better.

> so what about
>
>  #include <cctype>
>
>  inline int xisascii (int c) { return isascii (c); }
>  inline int xtoascii (int c) { return toascii (c); }
>
>  #undef isascii
>  #undef toascii

This should be fine: put this into some lo-cctype.h header and
include it in ov-base.h should be enough to make MSVC happy
(I'll merge my repo with yours and try to recompile once you
commit the change).

Another related problem is with ::round use in ov-scalar.cc:
MSVC does not have ::round, but as liboctave already defines
xround, could we use it instead in SCALAR_MAPPER(round, ::round)?

Michael.