octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Compilation fixes: remove extern template and add declaratio


From: Jason Riedy
Subject: Re: [PATCH] Compilation fixes: remove extern template and add declarations.
Date: Tue, 12 Feb 2008 15:17:21 -0800
User-agent: Gnus/5.110007 (No Gnus v0.7) Emacs/23.0.60 (gnu/linux)

And Michael Goffioul writes:
>
> The intent was to declare that there are explicit specializations
> implemented in another file and prevent the compiler to instantiate
> functions for these cases (this lead to symbol multiple definition
> error at link time with MSVC).

Those aren't specializations, they're overrides.  Just use
  extern bool ascending_compare (double, double);
without the template<> here and define the functions elsewhere.
Overrides in the active namespaces are found first, iirc.

> With you patch, what will the compiler do?

With g++ 4.3?  It compiled octave, ran the tests, and let me
poke at the xGELSD problem.  ;)  I didn't look further.

Jason


reply via email to

[Prev in Thread] Current Thread [Next in Thread]