[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Graphics properties implementation
From: |
Michael Goffioul |
Subject: |
Re: Graphics properties implementation |
Date: |
Sat, 12 Jan 2008 13:00:31 +0100 |
On 1/12/08, John W. Eaton <address@hidden> wrote:
> OK, I applied the patch and checked it in. I needed the attached
> changes to get a clean compile of graphics.cc. Most of the changes
> had to do with the GCC warning option -Wshadow.
>
> Was there some reason to omit the name handle arguments in some of the
> calls to the base_property constructor? I added them, but if there
> were intentionally omitted, I can undo that part of my patch.
No, this was a mistake. I detected 3 of them in array_property, any_property
and callback_property respectively. Am I right?
> I think graphics-props.cc should appear in the Makefile somewhere as a
> dependency.
Something like in the attachment?
Michael.
graphics-props.diff
Description: Text document
- Graphics properties implementation, Michael Goffioul, 2008/01/11
- Re: Graphics properties implementation, David Bateman, 2008/01/11
- Re: Graphics properties implementation, Shai Ayal, 2008/01/12
- Graphics properties implementation, John W. Eaton, 2008/01/12
- Re: Graphics properties implementation,
Michael Goffioul <=
- Re: Graphics properties implementation, Michael Goffioul, 2008/01/12
- Re: Graphics properties implementation, Shai Ayal, 2008/01/12
- Re: Graphics properties implementation, Michael Goffioul, 2008/01/12
- Re: Graphics properties implementation, John W. Eaton, 2008/01/12
- Re: Graphics properties implementation, Michael Goffioul, 2008/01/12
- Re: Graphics properties implementation, Shai Ayal, 2008/01/12
- Re: Graphics properties implementation, Michael Goffioul, 2008/01/15
- Re: Graphics properties implementation, John W. Eaton, 2008/01/15
- Re: Graphics properties implementation, Shai Ayal, 2008/01/12
- Re: Graphics properties implementation, Ben Abbott, 2008/01/12