[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Functions calls got slower between Octave 2.9.5 and 2.9.6 through .1
From: |
David Bateman |
Subject: |
Re: Functions calls got slower between Octave 2.9.5 and 2.9.6 through .10 |
Date: |
Fri, 27 Apr 2007 13:57:52 +0200 |
User-agent: |
Thunderbird 1.5.0.7 (X11/20060921) |
Luis F. Ortiz wrote:
> On Thu, 2007-04-26 at 17:13 -0400, John W. Eaton wrote:
>> On 22-Apr-2007, Luis F. Ortiz wrote:
>>
>> | As you can see, something went awry between Octave 2.9.5 and 2.9.6,
>> | and has stayed bad since, to
>> | the tune of 20% less goodness.
>>
>> The following patch will help slightly.
>>
> Sorry to be a pest this early in the morning, but I did not see the
> patch in a following message or this message.
> Did I miss it?
It's in the CVS, I did
cvs diff -u -r 1.74 -r 1.75 src/ov-usr-fcn.cc > patch
and attached the result to this message
D.
--
David Bateman address@hidden
Motorola Labs - Paris +33 1 69 35 48 04 (Ph)
Parc Les Algorithmes, Commune de St Aubin +33 6 72 01 06 33 (Mob)
91193 Gif-Sur-Yvette FRANCE +33 1 69 35 77 01 (Fax)
The information contained in this communication has been classified as:
[x] General Business Information
[ ] Motorola Internal Use Only
[ ] Motorola Confidential Proprietary
Index: src/ov-usr-fcn.cc
===================================================================
RCS file: /usr/local/cvsroot/octave/src/ov-usr-fcn.cc,v
retrieving revision 1.74
retrieving revision 1.75
diff -u -r1.74 -r1.75
--- src/ov-usr-fcn.cc 6 Apr 2007 16:11:38 -0000 1.74
+++ src/ov-usr-fcn.cc 27 Apr 2007 02:17:34 -0000 1.75
@@ -381,16 +381,19 @@
Cell varargout;
- symbol_record *sr = local_sym_tab->lookup ("varargout");
-
- if (sr && sr->is_variable ())
+ if (ret_list->takes_varargs ())
{
- octave_value v = sr->def ();
+ symbol_record *sr = local_sym_tab->lookup ("varargout");
+
+ if (sr && sr->is_variable ())
+ {
+ octave_value v = sr->def ();
- varargout = v.cell_value ();
+ varargout = v.cell_value ();
- if (error_state)
- error ("expecting varargout to be a cell array object");
+ if (error_state)
+ error ("expecting varargout to be a cell array object");
+ }
}
if (! error_state)