octave-maintainers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

MSVC compiler support [patch 16]: liboctave exported symbols


From: John W. Eaton
Subject: MSVC compiler support [patch 16]: liboctave exported symbols
Date: Thu, 26 Oct 2006 21:22:16 -0400

On 17-Oct-2006, Michael Goffioul wrote:

| Defines symbols exported by octave DLL.

I applied this patch, except for the part of this section that
undefines min and max.  Why is that needed here but not in any other
files that use min or max?

| Index: liboctave/oct-time.h
| ===================================================================
| RCS file: /cvs/octave/liboctave/oct-time.h,v
| retrieving revision 1.5
| diff -p -c -r1.5 oct-time.h
| *** liboctave/oct-time.h      26 Apr 2005 19:24:29 -0000      1.5
| --- liboctave/oct-time.h      17 Oct 2006 11:07:42 -0000
| *************** Software Foundation, Inc., 51 Franklin S
| *** 30,38 ****
| --- 30,44 ----
|   
|   #include "systime.h"
|   
| + #ifdef min
| + #undef min
| + #undef max
| + #endif
| + 
|   class octave_base_tm;
|   
|   class
| + OCTAVE_API
|   octave_time
|   {
|   public:

Thanks,

jwe


reply via email to

[Prev in Thread] Current Thread [Next in Thread]