[Octave-bug-tracker] [bug #65431] crash after hgload certain data

[Markus Mützel]

Update of bug #65431 (group octave):

                  Status:                    None => Patch Submitted        
         Planned Release:                    None => 9.1.0 (current stable) 

    _______________________________________________________

Follow-up Comment #6:

It looks like the code assumed that the number of color values in
"facevertexcdata" would match either the number of faces or the number of
vertices of the patch object. But it didn't actually check that.

The attached patch adds such a check.
With it, I see the following in the command window when I try to load the
.ofig from comment #0:

>> openfig patch_crash/sphere_crash.ofig
>> warning: opengl_renderer: number of facevertexcdata values matches neither
number of faces nor number of vertices.  Not rendering.
warning: opengl_renderer: number of facevertexcdata values matches neither
number of faces nor number of vertices.  Not rendering.
warning: opengl_renderer: number of facevertexcdata values matches neither
number of faces nor number of vertices.  Not rendering.
warning: opengl_renderer: number of facevertexcdata values matches neither
number of faces nor number of vertices.  Not rendering.


And the attached figure is shown.

Octave no longer crashes with it for me.


(file #55804, file #55805)

    _______________________________________________________

Additional Item Attachment:

File name: bug65431-patch-inconsistent-facevertexcdata.patch Size:1 KB
   
<https://file.savannah.gnu.org/file/bug65431-patch-inconsistent-facevertexcdata.patch?file_id=55804>

File name: sphere_crash.png               Size:36 KB
    <https://file.savannah.gnu.org/file/sphere_crash.png?file_id=55805>


    AGPL NOTICE

These attachments are served by Savane. You can download the corresponding
source code of Savane at
https://git.savannah.nongnu.org/cgit/administration/savane.git/snapshot/savane-04b18e1179b14c0ef710c8e9c8e59d1e4bcd7bd0.tar.gz


    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?65431>

_______________________________________________
Message sent via Savannah
https://savannah.gnu.org/