[Octave-bug-tracker] [bug #61704] Index vector related tests fail on macOS when compiled with visibility flags

[Markus Mützel]

URL:
  <https://savannah.gnu.org/bugs/?61704>

                 Summary: Index vector related tests fail on macOS when
compiled with visibility flags
                 Project: GNU Octave
            Submitted by: mmuetzel
            Submitted on: Sun 19 Dec 2021 04:39:37 PM CET
                Category: Interpreter
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Regression
                  Status: None
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
                 Release: 7.0.90
         Discussion Lock: Any
        Operating System: Mac OS

    _______________________________________________________

Details:

When Octave is compiled with visibility flags, some tests that are related to
indexing fail on macOS. See also bug #59820.

The failing tests on the macOS runners on GitHub:

>>>>> processing
/Users/runner/work/octave/octave/.build/liboctave/array/idx-vector.cc-tst
***** error id=Octave:index-out-of-bounds 1(find ([1,1] != 0))
!!!!! error failed.
Expected id=Octave:index-out-of-bounds, but got <>


>>>>> processing
/Users/runner/work/octave/octave/.build/libinterp/corefcn/sub2ind.cc-tst
***** error <index \(0,_,_\)> sub2ind ([10 10 10], 0, 1, 1)
!!!!! error failed.
Expected <index \(0,_,_\)>, but got <index 0: subscripts must be either
integers 1 to (2^63)-1 or logicals>

***** error <index \(_,0,_\)> sub2ind ([10 10 10], 1, 0, 1)
!!!!! error failed.
Expected <index \(_,0,_\)>, but got <index 0: subscripts must be either
integers 1 to (2^63)-1 or logicals>

***** error <index \(_,_,0\)> sub2ind ([10 10 10], 1, 1, 0)
!!!!! error failed.
Expected <index \(_,_,0\)>, but got <index 0: subscripts must be either
integers 1 to (2^63)-1 or logicals>

***** error <index \(1.5,_\)> sub2ind ([10 10], 1.5, 1)
!!!!! error failed.
Expected <index \(1.5,_\)>, but got <index 1.5: subscripts must be either
integers 1 to (2^63)-1 or logicals>

***** error <index \(_,1.5\)> sub2ind ([10 10], 1, 1.5)
!!!!! error failed.
Expected <index \(_,1.5\)>, but got <index 1.5: subscripts must be either
integers 1 to (2^63)-1 or logicals>

***** error <invalid index> ind2sub ([2, 2, 2], -1:8)
!!!!! error failed.
Expected <invalid index>, but got <index -1: subscripts must be either
integers 1 to (2^63)-1 or logicals>


>>>>> processing /Users/runner/work/octave/octave/test/index.tst
***** error <index \(0\): subscripts must be>     1(0)
!!!!! error failed.
Expected <index \(0\): subscripts must be>, but got <index 0: subscripts must
be either integers 1 to (2^63)-1 or logicals>

***** error <index \(-1\): subscripts must be>    1(-1)
!!!!! error failed.
Expected <index \(-1\): subscripts must be>, but got <index -1: subscripts
must be either integers 1 to (2^63)-1 or logicals>

***** error <index \(_,0.5\): subscripts>                 {}(1,0.5)
!!!!! error failed.
Expected <index \(_,0.5\): subscripts>, but got <index 0.5: subscripts must be
either integers 1 to (2^63)-1 or logicals>

***** error <index \([Nn][aA][Nn],_\): subscripts>                 1(NaN,1)
!!!!! error failed.
Expected <index \([Nn][aA][Nn],_\): subscripts>, but got <index nan:
subscripts must be either integers 1 to (2^63)-1 or logicals>

***** error <index \(_,_,<cell....\[x8\]...\): subscripts>
[](1,1,{},1,1,1,1,1,1,1,1)
!!!!! error failed.
Expected <index \(_,_,<cell....\[x8\]...\): subscripts>, but got <index
<cell>: subscripts must be either integers 1 to (2^63)-1 or logicals>

***** error <index \(...\[x9\]...-1,_\): subscript>     
1(1,1,1,1,1,1,1,1,1,-1,1)
!!!!! error failed.
Expected <index \(...\[x9\]...-1,_\): subscript>, but got <index -1:
subscripts must be either integers 1 to (2^63)-1 or logicals>

***** error <index \(-1\): subscripts>                   1(1)(-1)(1)
!!!!! error failed.
Expected <index \(-1\): subscripts>, but got <index -1: subscripts must be
either integers 1 to (2^63)-1 or logicals>

***** error <abc\(3\): out of bound 2>      abc([false, true, true])
!!!!! error failed.
Expected <abc\(3\): out of bound 2>, but got <index (3): out of bound 2
(dimensions are 1x2)>

***** error <abc\(-1\): subscripts>         abc(-1)(1)(1)
 ## xerror <index \(-1\): subscripts> abc(1)(-1)(1)   ## why no 'xerror'
test?
!!!!! error failed.
Expected <abc\(-1\): subscripts>, but got <index -1: subscripts must be either
integers 1 to (2^63)-1 or logicals>

***** error <abc\(5\): out of bound 4>         abc(5)
!!!!! error failed.
Expected <abc\(5\): out of bound 4>, but got <index (5): out of bound 4
(dimensions are 2x2)>

***** error <abc\(_,3\): out of bound 2 \(dimensions are 2x2\)> abc(2,3)
!!!!! error failed.
Expected <abc\(_,3\): out of bound 2 \(dimensions are 2x2\)>, but got <index
(_,3): out of bound 2 (dimensions are 2x2)>

***** error <abc\(_,_,0.5\): subscripts>       exp (abc(2,3,0.5))
!!!!! error failed.
Expected <abc\(_,_,0.5\): subscripts>, but got <index 0.5: subscripts must be
either integers 1 to (2^63)-1 or logicals>

***** error <abc\(_,5\): out of bound 4>                            abc(2,5)
!!!!! error failed.
Expected <abc\(_,5\): out of bound 4>, but got <index (_,5): out of bound 4
(dimensions are 2x2x2)>

***** error <abc\(_,3,_\): out of bound 2 \(dimensions are 2x2x2\)>
abc(2,3,2)
!!!!! error failed.
Expected <abc\(_,3,_\): out of bound 2 \(dimensions are 2x2x2\)>, but got
<index (_,3,_): out of bound 2 (dimensions are 2x2x2)>

***** error <index \(-2,_\): subscripts>               eye (4)(-2,3)
!!!!! error failed.
Expected <index \(-2,_\): subscripts>, but got <index -2: subscripts must be
either integers 1 to (2^63)-1 or logicals>

***** error <abc\(_,0.3,_\): subscripts>  abc(2,0.3,5)
!!!!! error failed.
Expected <abc\(_,0.3,_\): subscripts>, but got <index 0.3: subscripts must be
either integers 1 to (2^63)-1 or logicals>

***** error <abc\(_,0.3,_\): subscripts>  abc{2,0.3,5}
!!!!! error failed.
Expected <abc\(_,0.3,_\): subscripts>, but got <index 0.3: subscripts must be
either integers 1 to (2^63)-1 or logicals>

***** error <abc\(-2,_,_,_\): subscripts> abc{-2,1,1,1}
!!!!! error failed.
Expected <abc\(-2,_,_,_\): subscripts>, but got <index -2: subscripts must be
either integers 1 to (2^63)-1 or logicals>

***** error <abc\(0,_,_,_\): subscripts>  abc(0,1,1,1) = 1
!!!!! error failed.
Expected <abc\(0,_,_,_\): subscripts>, but got <index 0: subscripts must be
either integers 1 to (2^63)-1 or logicals>

***** error <abc\([Nn][aA][Nn]\): subscripts>         abc(NA)
!!!!! error failed.
Expected <abc\([Nn][aA][Nn]\): subscripts>, but got <index nan: subscripts
must be either integers 1 to (2^63)-1 or logicals>

***** error <abc\(_,_,_,[Ii][nN][Ff],_\): subscripts> abc(1,1,1,Inf,1)
!!!!! error failed.
Expected <abc\(_,_,_,[Ii][nN][Ff],_\): subscripts>, but got <index inf:
subscripts must be either integers 1 to (2^63)-1 or logicals>

***** error <abc\(-1\): subscripts>                abc(-1)
!!!!! error failed.
Expected <abc\(-1\): subscripts>, but got <index -1: subscripts must be either
integers 1 to (2^63)-1 or logicals>

***** error <abc\(-1\): subscripts>                abc(-1) = 1
!!!!! error failed.
Expected <abc\(-1\): subscripts>, but got <index -1: subscripts must be either
integers 1 to (2^63)-1 or logicals>

***** error <abc\(-1,_\): subscripts>              abc(-1,1)
!!!!! error failed.
Expected <abc\(-1,_\): subscripts>, but got <index -1: subscripts must be
either integers 1 to (2^63)-1 or logicals>

***** error <abc\(-1,_\): subscripts>              abc(-1,1) = 1
!!!!! error failed.
Expected <abc\(-1,_\): subscripts>, but got <index -1: subscripts must be
either integers 1 to (2^63)-1 or logicals>

***** error <abc\(4,_\): out of bound 3 \(dimensions are 3x3\)> abc(4,1)
!!!!! error failed.
Expected <abc\(4,_\): out of bound 3 \(dimensions are 3x3\)>, but got <index
(4,_): out of bound 3 (dimensions are 3x3)>

***** error <abc\(-1\): subscripts>             abc(-1)
!!!!! error failed.
Expected <abc\(-1\): subscripts>, but got <index -1: subscripts must be either
integers 1 to (2^63)-1 or logicals>

***** error <abc\(-1,_\): subscripts>           abc(-1,1)
!!!!! error failed.
Expected <abc\(-1,_\): subscripts>, but got <index -1: subscripts must be
either integers 1 to (2^63)-1 or logicals>

***** error <abc\(4,_\): out of bound 1 \(dimensions are 1x10\)> abc(4,1)
!!!!! error failed.
Expected <abc\(4,_\): out of bound 1 \(dimensions are 1x10\)>, but got <index
(4,_): out of bound 1 (dimensions are 1x10)>


>>>>> processing /Users/runner/work/octave/octave/test/logical-index.tst
***** error id=Octave:index-out-of-bounds a(logical ([1,1]))
!!!!! error failed.
Expected id=Octave:index-out-of-bounds, but got <>


>>>>> processing /Users/runner/work/octave/octave/test/struct.tst
***** error id=Octave:index-out-of-bounds
 a(1).x.x = 1;
 a(2).x;
!!!!! error failed.
Expected id=Octave:index-out-of-bounds, but got <>

***** error id=Octave:index-out-of-bounds
 s = resize (struct (),3,2);
 s(3).foo = 42;
 s(7);
!!!!! error failed.
Expected id=Octave:index-out-of-bounds, but got <>


It looks like some expression don't result in an error when they should. Or
they result in a different error.
In some cases, it looks like the "base" implementation of the error message is
displayed instead of a specialization.

I set the release to 7.0.90 because it would be nice to have that sorted out
for Octave 7. However, we already default to not build with visibility flags
on that platform (on the stable branch).




    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?61704>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/