[Octave-bug-tracker] [bug #60298] build with Qt 5.4.broken after rotated tabs implementation

[A.R. Burgers]

URL:
  <https://savannah.gnu.org/bugs/?60298>

                 Summary: build with Qt 5.4.broken after rotated tabs
implementation
                 Project: GNU Octave
            Submitted by: arb
            Submitted on: Mon 29 Mar 2021 07:08:25 AM UTC
                Category: GUI
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Build Failure
                  Status: None
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
                 Release: dev
         Discussion Lock: Any
        Operating System: GNU/Linux

    _______________________________________________________

Details:

The recent change set http://hg.savannah.gnu.org/hgweb/octave/rev/80457383d5e1
breaks building with Qt 5.4 with these errors:


  CXX      libgui/src/libgui_src_libgui_src_la-tab-bar.lo                     
                                    
../octave/libgui/src/tab-bar.cc: In member function 'virtual void
octave::tab_bar::mousePressEvent(QMouseEvent*)':
../octave/libgui/src/tab-bar.cc:178:67: error: no matching function for call
to 'QAction::QAction(QIcon, QString)'
  178 |                 QAction* a = new QAction (tabIcon (i), tabText (i));
      |                                                                   ^
In file included from
/apps/shared/Qt/5.4/gcc_64/include/QtWidgets/qmenu.h:40,
                 from /apps/shared/Qt/5.4/gcc_64/include/QtWidgets/QMenu:1,
                 from ../octave/libgui/src/tab-bar.h:32,
                 from ../octave/libgui/src/tab-bar.cc:33:
/apps/shared/Qt/5.4/gcc_64/include/QtWidgets/qaction.h:174:5: note: candidate:
'QAction::QAction(QActionPrivate&, QObject*)'
  174 |     QAction(QActionPrivate &dd, QObject *parent);
      |     ^~~~~~~
/apps/shared/Qt/5.4/gcc_64/include/QtWidgets/qaction.h:174:29: note:   no
known conversion for argument 1 from 'QIcon' to 'QActionPrivate&'
  174 |     QAction(QActionPrivate &dd, QObject *parent);
      |             ~~~~~~~~~~~~~~~~^~
/apps/shared/Qt/5.4/gcc_64/include/QtWidgets/qaction.h:89:5: note: candidate:
'QAction::QAction(const QIcon&, const QString&, QObject*)'
   89 |     QAction(const QIcon &icon, const QString &text, QObject* parent);
      |     ^~~~~~~
/apps/shared/Qt/5.4/gcc_64/include/QtWidgets/qaction.h:89:5: note:   candidate
expects 3 arguments, 2 provided
/apps/shared/Qt/5.4/gcc_64/include/QtWidgets/qaction.h:88:5: note: candidate:
'QAction::QAction(const QString&, QObject*)'
   88 |     QAction(const QString &text, QObject* parent);
      |     ^~~~~~~
/apps/shared/Qt/5.4/gcc_64/include/QtWidgets/qaction.h:88:28: note:   no known
conversion for argument 1 from 'QIcon' to 'const QString&'
   88 |     QAction(const QString &text, QObject* parent);
      |             ~~~~~~~~~~~~~~~^~~~
/apps/shared/Qt/5.4/gcc_64/include/QtWidgets/qaction.h:87:14: note: candidate:
'QAction::QAction(QObject*)'
   87 |     explicit QAction(QObject* parent);
      |              ^~~~~~~
/apps/shared/Qt/5.4/gcc_64/include/QtWidgets/qaction.h:87:14: note:  
candidate expects 1 argument, 2 provided





    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?60298>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/