[Octave-bug-tracker] [bug #59731] wrong colorbar length when aspect ratio is manual

[Hg200]

Follow-up Comment #10, bug #59731 (project octave):

Ok, I am attaching my latest patch on this topic plus two test cases that
better illustrate the various problems (run in subdir, will generate a lot
files). Unfortunately, this bug implies "either rewrite everything" or "make
as few changes as possible". If I recall correctly, I went through the various
colorbar scenarios that can occur (manual, auto, quite a lot ...) and checked
if the changes in the attached patch were OK. The patch cleans up
__actual_axis_position__.m and moves the code to colorbar.m. The downside of
this approach is that __actual_axis_position__.m is unfortunately also used in
the gnuplot front end. But I never figured out under which circumstances the
function is called. Unfortunately I had to stop working on it, sorry.

What does the patch do now and what is the confidence? 

1.) IMO it fixes the colorbar problem in the Qt frontend and solves the unit
problem.
2.) The gnuplot frontend was already broken before (you may run the test
scripts with gnuplot), but with the patch it is probably even more broken (i
guess).

Ps.: The patch is rather old and fails because Octave source files seems now
have the year "2021" instead of "2020". Anyway the test cases still look fine
over here.



(file #51040, file #51041, file #51042)
    _______________________________________________________

Additional Item Attachment:

File name: patch_colorbar_v4.diff         Size:11 KB
    <https://file.savannah.gnu.org/file/patch_colorbar_v4.diff?file_id=51040>

File name: colorbartest_1.m               Size:2 KB
    <https://file.savannah.gnu.org/file/colorbartest_1.m?file_id=51041>

File name: colorbartest_2.m               Size:1 KB
    <https://file.savannah.gnu.org/file/colorbartest_2.m?file_id=51042>



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?59731>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/