[Octave-bug-tracker] [bug #60162] Conflicting types for octave_iconv_open_wrapper and octave_iconv_close_wrapper

[Rik]

Follow-up Comment #1, bug #60162 (project octave):

The issue is that iconv-wrappers.c #includes "iconv.h" while iconv-wrappers.h
does not.

In iconv-wrappers.c, because it has included the iconv.h header file it can
make use of the iconv_t definition which is a typedef.  On Linux systems, the
definition in /usr/include/iconv.h is


typedef void *iconv_t;


which is a pointer to void.

Hence, in iconv-wrapers.h it is okay to directly write


void *


where one wants iconv_t.

Apparently Solaris defines iconv_t to a different value.

I'm adding jwe to the CC list as he knows more about why these wrappers are
written the way they are.

Possible solution #1

Add '#include "iconv.h"' to the file iconv-wrapper.h and then use iconv_t to
define functions.

This seems cleanest, but maybe there is a reason not to expose system header
files?  On the other hand, several of the header files in the
liboctave/wrappers directory use '#include <sys/types.h>'.

Possible solution #2

Use #ifdef based on OS (Solaris vs. NOT Solaris) in iconv-wrapper.h to choose
between using a pointer to void or the data type used on Solaris for iconv_t.
 



    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?60162>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/