[Octave-bug-tracker] [bug #59004] Error when trying to build of-communications (constness of cat op args)

[Markus Mützel]

URL:
  <https://savannah.gnu.org/bugs/?59004>

                 Summary: Error when trying to build of-communications
(constness of cat op args)
                 Project: GNU Octave
            Submitted by: mmuetzel
            Submitted on: Mon 24 Aug 2020 01:52:52 PM CEST
                Category: Interpreter
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Regression
                  Status: None
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
                 Release: dev
         Discussion Lock: Any
        Operating System: Any

    _______________________________________________________

Details:

Building the communication package with a current default branch stops with
this error:

x86_64-w64-mingw32-g++ -c
-I/home/osboxes/Repositories/Octave/mxe-octave-1/usr/x86_64-w64-mingw32/include
 
-I/home/osboxes/Repositories/Octave/mxe-octave-1/usr/x86_64-w64-mingw32/include/octave-7.0.0/octave/..
-I/home/osboxes/Repositories/Octave/mxe-octave-1/usr/x86_64-w64-mingw32/include/octave-7.0.0/octave
-I/home/osboxes/Repositories/Octave/mxe-octave-1/usr/x86_64-w64-mingw32/include
  -fopenmp -g -O2    -DGALOIS_DISP_PRIVATES -DHAVE_CONFIG_H op-gm-gm.cc -o
op-gm-gm.o
In file included from op-gm-gm.cc:30:
op-gm-gm.cc: In function 'void install_gm_gm_ops(octave::type_info&)':
/home/osboxes/Repositories/Octave/mxe-octave-1/usr/x86_64-w64-mingw32/include/octave-7.0.0/octave/../octave/ops.h:62:59:
error: invalid conversion from 'octave_value (*)(octave_base_value&, const
octave_base_value&, const Array<long long int>&)' to
'octave::type_info::cat_op_fcn' {aka 'octave_value (*)(const
octave_base_value&, const octave_base_value&, const Array<long long int>&)'}
[-fpermissive]
   62 |   (t1::static_type_id (), t2::static_type_id (), CONCAT2 (oct_catop_,
f));
      |                                                           ^~~~~~~~~~
      |                                                           |
      |                                                           octave_value
(*)(octave_base_value&, const octave_base_value&, const Array<long long
int>&)
/home/osboxes/Repositories/Octave/mxe-octave-1/usr/x86_64-w64-mingw32/include/octave-7.0.0/octave/../octave/ops.h:39:24:
note: in definition of macro 'CONCAT2X'
   39 | #define CONCAT2X(x, y) x ## y
      |                        ^
/home/osboxes/Repositories/Octave/mxe-octave-1/usr/x86_64-w64-mingw32/include/octave-7.0.0/octave/../octave/ops.h:62:50:
note: in expansion of macro 'CONCAT2'
   62 |   (t1::static_type_id (), t2::static_type_id (), CONCAT2 (oct_catop_,
f));
      |                                                  ^~~~~~~
op-gm-gm.cc:158:3: note: in expansion of macro 'INSTALL_CATOP_TI'
  158 |   INSTALL_CATOP_TI (ti, octave_galois, octave_galois, gm_gm);
      |   ^~~~~~~~~~~~~~~~
In file included from
/home/osboxes/Repositories/Octave/mxe-octave-1/usr/x86_64-w64-mingw32/include/octave-7.0.0/octave/../octave/ov-fcn.h:38,
                 from
/home/osboxes/Repositories/Octave/mxe-octave-1/usr/x86_64-w64-mingw32/include/octave-7.0.0/octave/../octave/ov-builtin.h:35,
                 from
/home/osboxes/Repositories/Octave/mxe-octave-1/usr/x86_64-w64-mingw32/include/octave-7.0.0/octave/../octave/defun-int.h:33,
                 from
/home/osboxes/Repositories/Octave/mxe-octave-1/usr/x86_64-w64-mingw32/include/octave-7.0.0/octave/../octave/defun-dld.h:35,
                 from
/home/osboxes/Repositories/Octave/mxe-octave-1/usr/x86_64-w64-mingw32/include/octave-7.0.0/octave/../octave/oct.h:35,
                 from op-gm-gm.cc:24:
/home/osboxes/Repositories/Octave/mxe-octave-1/usr/x86_64-w64-mingw32/include/octave-7.0.0/octave/../octave/ov-typeinfo.h:121:53:
note:   initializing argument 3 of 'bool
octave::type_info::install_cat_op(int, int, octave::type_info::cat_op_fcn)'
  121 |     bool install_cat_op (int t1, int t2, cat_op_fcn f)
      |                                          ~~~~~~~~~~~^
make[2]: *** [Makefile:44: op-gm-gm.o] Error 1


This is probably related to this changeset:
https://hg.savannah.gnu.org/hgweb/octave/rev/35f974bab4c8

fix constness of cat op args

Declare the first argument of the cat_op concatenation operators const.

* ov-typeinfo.h (cat_op_fcn): Make first argument of concatenation
operator typedef const.

* op-b-sbm.cc, op-bm-sbm.cc, op-chm.cc, op-cm-scm.cc, op-cm-sm.cc,
op-cs-scm.cc, op-cs-sm.cc, op-m-scm.cc, op-m-sm.cc, op-s-scm.cc,
op-s-sm.cc, op-sbm-b.cc, op-sbm-bm.cc, op-scm-cm.cc, op-scm-cs.cc,
op-scm-m.cc, op-scm-s.cc, op-sm-cm.cc, op-sm-cs.cc, op-sm-m.cc,
op-sm-s.cc, op-struct.cc: Fix concatentation operator declarations and
casts as needed.
* ops.h (DEFCATOPX, DEFCATOP, DEFCATOP_FN, DEFNDCATOP_FN,
DEFNDCHARCATOP_FN, DEFNDCATOP_FN2): Likewise.
author  John W. Eaton <jwe@octave.org>
date    Thu, 30 Jul 2020 16:15:03 -0400 (3 weeks ago)


Should the old function prototype be restored and properly deprecated?




    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?59004>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/