[Octave-bug-tracker] [bug #57867] strrep: unexpected substitution behavior on a char array

[Mike Miller]

Follow-up Comment #60, bug #57867 (project octave):

I don't know what to tell you. You attached a file 'strrep.diff' on April 21,
which looks like a proper Mercurial commit export.

When I apply that patch to the Octave default branch, the patch applies
cleanly. But I get the following when I try to build it


../libinterp/corefcn/strfind.cc: In function ‘octave_value_list
Fstrrep(const octave_value_list&, int)’:
../libinterp/corefcn/strfind.cc:457:5: error: expected ‘}’ before
‘else’
  457 |     else if (argstr.iscell ())
      |     ^~~~
../libinterp/corefcn/strfind.cc:445:3: note: to match this ‘{’
  445 |   {
      |   ^
../libinterp/corefcn/strfind.cc:430:16: warning: control reaches end of
non-void function [-Wreturn-type]
  430 |   octave_value retval;
      |                ^~~~~~


If you have made changes that build for you, then maybe you should check that
the latest patch file here actually matches the changes you intended.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?57867>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/