[Octave-bug-tracker] [bug #58293] importdata doesn't like empty header lines

[Fabio]

URL:
  <https://savannah.gnu.org/bugs/?58293>

                 Summary: importdata doesn't like empty header lines
                 Project: GNU Octave
            Submitted by: efferre79
            Submitted on: Sat 02 May 2020 05:26:06 PM UTC
                Category: Octave Function
                Severity: 3 - Normal
                Priority: 5 - Normal
              Item Group: Regression
                  Status: None
             Assigned to: None
         Originator Name: 
        Originator Email: 
             Open/Closed: Open
                 Release: 5.2.0
         Discussion Lock: Any
        Operating System: GNU/Linux

    _______________________________________________________

Details:

The commit http://hg.savannah.gnu.org/hgweb/octave/rev/75f7e8728e17 introduced
a regression (octave 4.4.1 was working fine), moreover empty lines are now
discarded from the header section of the datafile.

I am adding here a patch to solve the problem, you can see a line of code
where I consider the possibility to encounter old Mac files (the \r is used as
line separator), feel free to remove that part if you don't consider that
support important in octave.

I have updated also the BITS to test the new functionality, here I have also
attached two sample log file to analyze. All the BITS have been successfully
tested on Linux and Windows.





    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sat 02 May 2020 05:26:06 PM UTC  Name: importdata.m.patch  Size: 1KiB  
By: efferre79

<http://savannah.gnu.org/bugs/download.php?file_id=48986>
-------------------------------------------------------
Date: Sat 02 May 2020 05:26:06 PM UTC  Name: test_CRLF.log  Size: 93B   By:
efferre79

<http://savannah.gnu.org/bugs/download.php?file_id=48987>
-------------------------------------------------------
Date: Sat 02 May 2020 05:26:06 PM UTC  Name: test_LF.log  Size: 85B   By:
efferre79

<http://savannah.gnu.org/bugs/download.php?file_id=48988>

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?58293>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/