octave-bug-tracker
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Octave-bug-tracker] [bug #57627] Validator functions (mustBe*) implemen


From: Kai Torben Ohlhus
Subject: [Octave-bug-tracker] [bug #57627] Validator functions (mustBe*) implementation
Date: Sat, 18 Jan 2020 13:22:44 -0500 (EST)
User-agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.130 Safari/537.36

Follow-up Comment #3, bug #57627 (project octave):

> Based on the discussion at
https://lists.gnu.org/archive/html/octave-maintainers/2020-01/msg00075.html, I
thought we were no longer including copyright notices in the individual files?
I actually had copyright headers in there originally, and went through and
removed them. :) Did I misunderstand what was meant by moving to centralized
copyright notices?

Yes Octave core has a "standard" copyright header now.  Then maintaining the
copyright year becomes even more scriptable.
 
> Sorry for causing you additional work. Some day I'll get good enough with
Octave code style that my patches won't require futzing with for style
purposes.

Actually, I am no 100% expert either.  I just orient myself in the neighboring
files and the wiki ;-)

> If this gets merged, I'll go through and add BISTs for all of them. I just
didn't know what was the right form for writing a BIST that tests
"such-and-such should raise an error".

Then you can wait until tomorrow (JST), then after building Octave again
(seeing if I broke something). I push patch v2 and you can provide a second
patch with only BIST tests if I am too lazy to write them.

    _______________________________________________________

Reply to this item at:

  <https://savannah.gnu.org/bugs/?57627>

_______________________________________________
  Message sent via Savannah
  https://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]