[Net::FTPServer] Fwd: Feedback about freeware/netftpserver page

[Richard W.M. Jones]

Thanks Heather,

I've added this to CVS.

Rich.

----- Forwarded message from www-data <address@hidden> -----

Subject: Wiki feedback: Feedback about freeware/netftpserver page

This is an automatically generated message from the feedback form at
www.annexia.org.  Someone has filled out this form and sent it to you
below.

----------------------------------------------------------------------
Feedback about page http://www.annexia.org/freeware/netftpserver:

Name:    Heather Sherman
Email:   address@hidden

Feedback:

I'm making use of your great Net::FTPServer module to provide a simple little 
embedded FTPServer that runs on demand (I'm doing backups of a network device 
that only supports FTP push and I don't maintain a permanent FTP server).  I'm 
subclassing using Net::FTPServer::InMem::Server as a model and the various 
hooks are quite handy!

The only problem I've run into is that a "-p 0" is not respected because the 
code is testing ($port) instead of testing to (defined $port) when processing 
options.  Choosing "-p 0" should let me have the OS select the port (and my 
child feeds back the port information to the parent to give to the network 
device).  The following patch fixes this problem . . . 

Heather 

Patch:
--- FTPServer.orig      2006-06-27 14:41:51.000000000 -0700
+++ FTPServer.pm        2006-06-27 14:39:41.000000000 -0700
@@ -3376,7 +3376,7 @@
     # Magically update configuration values with command line
     # argument values. Thus configuration entered on the command
     # line will override those present in the configuration file.
-    if ($port)
+    if (defined $port)
       {
        $self->_set_config ("port", $port, splat => 1);
       }
----------------------------------------------------------------------

----- End forwarded message -----

-- 
Richard Jones, CTO Merjis Ltd.
Merjis - web marketing and technology - http://merjis.com
Team Notepad - intranets and extranets for business - http://team-notepad.com