[myexperiment-hackers] [2680] trunk/app/controllers/reviews_controller.rb: Fix error during auth.

[noreply]

Revision

2680

Author

dtm

Date

2011-08-24 04:44:27 -0400 (Wed, 24 Aug 2011)

Log Message

Fix error during auth. Guard against reviewable being nil.

Modified Paths

• trunk/app/controllers/reviews_controller.rb

Diff

Modified: trunk/app/controllers/reviews_controller.rb (2679 => 2680)

--- trunk/app/controllers/reviews_controller.rb	2011-08-22 16:29:51 UTC (rev 2679)
+++ trunk/app/controllers/reviews_controller.rb	2011-08-24 08:44:27 UTC (rev 2680)
@@ -137,7 +137,7 @@
           error("Workflow not found (id not authorized)", "is invalid (not authorized)")
           return false
         else
-          find_reviewable_auth if login_required
+          login_required
         end
       end
     rescue ActiveRecord::RecordNotFound
@@ -147,7 +147,11 @@
   end
   
   def find_reviews
-    @reviews = @reviewable.reviews
+    if @reviewable
+      @reviews = @reviewable.reviews
+    else
+      @reviews = []
+    end
   end
   
   def find_review