[myexperiment-hackers] [2028] branches/event_logging/app/helpers/application_helper.rb: News.

[noreply]

Revision

2028

Author

alekses6

Date

2008-12-03 06:04:12 -0500 (Wed, 03 Dec 2008)

Log Message

News. Presentation of news entries changed:

1) in "X joined myExperiment" - myExperiment is no longer clickable;
2) in "X commented / reviewed Y" - news entry template changed to "X made a comment / review of Y" to make it consistent with other news entries.

Modified Paths

• branches/event_logging/app/helpers/application_helper.rb

Diff

Modified: branches/event_logging/app/helpers/application_helper.rb (2027 => 2028)

--- branches/event_logging/app/helpers/application_helper.rb	2008-12-03 10:40:32 UTC (rev 2027)
+++ branches/event_logging/app/helpers/application_helper.rb	2008-12-03 11:04:12 UTC (rev 2028)
@@ -2176,7 +2176,7 @@
             authorized = ( my_event || object.authorized?("view", current_viewer) )
             
             if authorized
-              rtn << [timestamp, "#{culprit_link} #{link_to "commented", object_path + "#comment_" + comment.id.to_s} on #{link_to object_visible_name, object_path} #{model_visible_name(log_entry.referenced_type.to_s, true, object)}.", "Comments"]
+              rtn << [timestamp, "#{culprit_link} <span class='news_feed_action'>made</span> a #{link_to "comment", object_path + "#comment_" + comment.id.to_s} on #{link_to object_visible_name, object_path} #{model_visible_name(log_entry.referenced_type.to_s, true, object)}.", "Comments"]
             end
           rescue ActiveRecord::RecordNotFound
             # do nothing, but don't display the news entry for missing comment / object
@@ -2204,7 +2204,7 @@
             authorized = ( my_event || object.authorized?("view", current_viewer) )
             
             if authorized
-              rtn << [timestamp, "#{culprit_link} #{link_to_unless reviewed_link.nil?, (reviewed_link.nil? ? "<span class='news_feed_action'>reviewed</span>" : "reviewed"), reviewed_link} #{link_to object_visible_name, object_path} #{model_visible_name(log_entry.referenced_type.to_s, true, object)}#{review_title_link}.", "Reviews"]
+              rtn << [timestamp, "#{culprit_link} <span class='news_feed_action'>made</span> a #{link_to_unless reviewed_link.nil?, "review", reviewed_link} of #{link_to object_visible_name, object_path} #{model_visible_name(log_entry.referenced_type.to_s, true, object)}#{review_title_link}.", "Reviews"]
             end
           rescue ActiveRecord::RecordNotFound
             # do nothing, but don't display the news entry for missing review / object
@@ -2337,7 +2337,7 @@
             user_link = name(log_entry.activity_loggable_id, nil, false)
             return nil if user_link.nil?
             
-            rtn << [timestamp, "#{user_link} <span class='news_feed_action'>joined</span> #{link_to "myExperiment", "/"}.", "New Users"]
+            rtn << [timestamp, "#{user_link} <span class='news_feed_action'>joined</span> myExperiment.", "New Users"]
           when "update"
             # for now this event is not shown to anyone - event to the user themself,
             # partly because every time when user logs in "last seen" field is set, which