[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Monotone-devel] Re: [PATCH] Make "mtn log" show the signer of changelog
From: |
Luke Schierer |
Subject: |
[Monotone-devel] Re: [PATCH] Make "mtn log" show the signer of changelog/comment certs |
Date: |
Mon, 7 Jan 2008 13:28:45 -0500 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
On Sat, Jan 05, 2008 at 11:47:42AM -0600, Richard Laager wrote:
> The Pidgin project has been using --author to credit patch submitters.
> Currently, though, it's not very easy to tell who committed the revision
> when looking at log messages. I also find it odd to see a patch with an
> author of "Bob" and a changelog message of "A patch from Bob that does
> [blah]. I modified this a bit, ....". Additionally, you can't easily
> tell who used "mtn comment".
>
> The attached patch solves these three issues by displaying the signer of
> the cert when the cert is multiline. This is currently only the case for
> changelog and comment certs. I think this behavior is likely to be
> desired if further multiline certs were added to the log output. Plus,
> the function I modified is internal to this file anyway.
>
> Richard
>
I am a fan of this change.
luke