Re: [Monotone-devel] Fw: [bug #21706] automate packet IO broken on 0.37

[Zbigniew Zagórski]

2007/12/3, Nathaniel Smith <address@hidden>:
> So people don't miss this...
> $ mtn automate packet_for_rdata 73523223ab76d83954f6284243c69a5b3726b91d
>         | mtn read
> mtn: warning: unknown packet type: 'rdata'
> mtn: misuse: no packets found on stdin

Well, after a small  investigation I see that packet.cc was rewritten
some time ago (probably together with regex changes) and following
strange lines were added:

    if (type == "rdata")
      data_packet(args, body, true);
    if (type == "fdata")  // should be else if
      data_packet(args, body, false);
    else if (type == "fdelta")
     ....
    else
      {
        W(F("unknown packet type: '%s'") % type);
        return;
      }

so looks like rdata packet is actually read, message is warning only.
After some checks i see that revision finally lands in destination db.

I don't have machinery for building monotone but following patch
should fix this warning.

--- packet.cc   35ad4a2b884b276ff41d03d4efd9fb6e9b62d048
+++ packet.cc   58beaca7a4c3e03fa496a34a11107f2fb12cb4b9
@@ -242,7 +242,7 @@ feed_packet_consumer
   {
     if (type == "rdata")
       data_packet(args, body, true);
-    if (type == "fdata")
+    else if (type == "fdata")
       data_packet(args, body, false);
     else if (type == "fdelta")
       fdelta_packet(args, body);

Sorry for false alarm.

-----

But still there is something wrong (or only changed) in packet IO
because mtn read used by mtndumb (net.venge.monotone.dumb) fails
miserably with following error:

    mtn: error: malformed packet: too many arguments in header

I'm investigating issue (i don't know what packet sequence is causing
this error) if this was mtndumb or mtn issue (i don't have to say that
on 0.36
everything worked perfectly).

Regards,
-- 
Zbigniew -zbigg- Zagórski
-- software developer -- geek -- happy daddy --