[Monotone-debian] Bug#624779: monotone: FTBFS on hurd-i386

[Pino Toscano]

Package: monotone
Version: 1.0-2
Severity: important
Tags: patch
User: address@hidden
Usertags: hurd

Hi,

currently[1] monotone fails to build on hurd-i386.
The problem is due to the usage of MAXPATHLEN, which is not defined on Hurd
(as there is no length contraint for paths).
The attached patch does the following fixes:
- src/netxx/serverbase.cxx, Netxx::ServerBase::bind_to():
  use glibc's get_current_dir_name() if no PATH_MAX (the correct define to
  eventually use) is defined, or use the current getcwd() way; in both the
  cases, the cwd read is done just once at the beginning of the function,
  instead of being done everytime in the for loop
  (also, couldn't this file eventually use get_current_working_dir() from fs?)
- src/unix/fs.cc, get_current_working_dir():
  use the same working patters as above, making use of PATH_MAX instead of
  hardcoding 4096 as size

Also, after the (log!) test suite run I got just three failures:
 60 automate_certs                                FAIL (line 2) 0:09, 0:00 on 
CPU
177 database_dump_load                            FAIL (line 25) 1:08, 0:00 on 
CPU
  2 bash_completion                               FAIL (line 43) 0:49, 0:00 on 
CPU
I haven't investigated them yet, but I guess they don't sound something that
would make monotone unusable (especially as the other 600+ test cases pass).

[1] 
https://buildd.debian.org/status/fetch.php?pkg=monotone&arch=hurd-i386&ver=1.0-2&stamp=1304200144

Thanks,
-- 
Pino

hurd.diff
Description: Text Data