monit-general
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[monit] Patch for protocols/radius.c


From: Alan DeKok
Subject: [monit] Patch for protocols/radius.c
Date: Sun, 09 May 2010 12:27:17 +0200
User-agent: Thunderbird 2.0.0.24 (Macintosh/20100228)

  It looks like there's a minor bug in protocols/radius.c.  I'm not sure
 how it was missed, but the new code (attached) is better.

  Alan DeKok.
Index: protocols/radius.c
===================================================================
--- protocols/radius.c  (revision 190)
+++ protocols/radius.c  (working copy)
@@ -239,7 +239,7 @@
       return FALSE;
     }
 
-    if (attr[1] > length) {
+    if (attr[1] > left) {
       LogError("RADIUS: message has attribute that is too long\n");
       return FALSE;
     }
@@ -248,6 +248,8 @@
     if (attr[0] == 0x50) {
       /* FIXME: validate it */
     }
+
+    left -= attr[1];
   }
 
   /* save the reply authenticator, and copy the request authenticator over */

reply via email to

[Prev in Thread] Current Thread [Next in Thread]