Re: [monit] MONIT_DESCRIPTION returning old description not new one

[Martin Pala]

The fix should be relatively easy ... the problem is, that the 
MONIT_DESCRIPTION returns currently error described by first 
s->eventlist list member.

This is wrong ... the eventlist is list of all events which occurred and 
is used as state history. The eventlist provides information about 
frequency of given error and supports the logic which changes state only 
when given error rate is matched. Some of these events may thus be 
inactive, some of them active.

In order to get correct information the handle_action() in event.c 
should call the control_service() with event as additional argument. It 
will allow to get the correct description of the error which is set in 
set_monit_environment(). See event.c for how event engine works and 
control.c + spawn.c for program execution.

We're very busy now, so if you want to give it a stab it will help, 
patches are welcomed :)

Martin


index one wrote:
> Thanks for the info,
> Anything that I can do to help / check?
> Is it an easy fix / likely to be fixed soon?
> Maybe if you could point me in the right direction I could look at
> fixing myself / getting someone to fix it and submit a patch.
>
>
> Thanks for your help,
> John
>
> 2008/12/3 Martin Pala <address@hidden>:
> > Thanks for report, yes the MONIT_DESCRIPTION shows incorrect information
> > (points to first event only) ... we'll fix.
> >
> > Martin
> >
> >
> > On Nov 30, 2008, at 3:43 AM, index one wrote:
> >
> > > Hello,
> > > I currently have a problem with monit failing to return the correct
> > > MONIT_DESCRIPTION on one log file.
> > > I monitor about 6 log files and one of them on occasion returns an old
> > > message on a regex match and not the current message.
> > > When this happens it will continue sending the old message on every
> > > regex match for that file until monit is restarted.
> > > Currently I am only seeing this on one log file (heartbeat, ha-log).
> > > I have tried monit-5.0_beta4 and a patched version of monit-4.10.1
> > > that allows  MONIT_DESCRIPTION in exec
> > > Alert emails contain the correct $DESCRIPTION tag but the
> > > $MONIT_DESCRIPTION passed to exec is incorrect.
> > > the log-send.sh script sends the message as a snmp trap bit just
> > > echoing $MONIT_DESCRIPTION to a temp file has the same result
> > >
> > > -------------------------- test----------
> > > echo "ERROR" >> /var/logs/ha-log
> > > echo "WARN" >> /var/logs/ha-log
> > > output:
> > > content match [ERROR]
> > > content match [ERROR]
> > > --------------------------------------------
> > >
> > >
> > > OS is Solaris 10
> > > Below is my monitrc (monit is started from init)
> > >
> > > Any help appreciated
> > >
> > > set init
> > > set alert address@hidden #for testing
> > > set daemon 1
> > > set logfile /var/log/monit
> > > set httpd port 2812
> > > allow admin:monit
> > >
> > >
> > > check file raid-log with path /opt/StorMan/RaidEvtA.log
> > > ignore match /etc/opt/raid.nomatch
> > > if match /etc/opt/raid.match then
> > > exec "/usr/bin/log-send.sh raid"
> > >
> > > check file Apache-log with path /var/log/apache/error.log
> > > ignore match /etc/opt/Apache.nomatch
> > > if match /etc/opt/Apache.match then
> > > exec "/usr/bin/log-send.sh Apache-log"
> > >
> > >
> > > check file Mysql-log with path /var/log/mysql/testserv1.err
> > > ignore match /etc/opt/Mysql.nomatch
> > > if match /etc/opt/Mysql.match then
> > > exec "/usr/bin/log-send.sh Mysql-log"
> > >
> > > check file Mysql-Replication-log with path /var/log/mysql/testserv1.err
> > > ignore match /etc/opt/Mysql-Replication.nomatch
> > > if match /etc/opt/Mysql-Replication.match then
> > > exec "/usr/bin/log-send.sh Mysql-Replication-log"
> > >
> > > check file ha-log with path /var/logs/ha-log
> > > ignore match /etc/opt/ha.nomatch
> > > if match /etc/opt/ha.match then
> > > exec "/usr/bin/log-send.sh ha-log"
> > >
> > > check file system-log with path /var/adm/messages
> > > ignore match /etc/opt/system.nomatch
> > > if match /etc/opt/system.match then
> > > exec "/usr/bin/log-send.sh system"
> > >
> > >
> > > --
> > > To unsubscribe:
> > > http://lists.nongnu.org/mailman/listinfo/monit-general
> >
> >
> > --
> > To unsubscribe:
> > http://lists.nongnu.org/mailman/listinfo/monit-general
>
>
> --
> To unsubscribe:
> http://lists.nongnu.org/mailman/listinfo/monit-general