Re: [Patch] Proc support for monit (preliminary, alpha^2)

[Jan-Henrik Haukeland]

Mark Ferlatte <address@hidden> writes:

> > Monit should not depend on other libraries like libgtop.  Anyways I read
> > though the code of libgtop and it doesn't look nice.  I need to have
> > some specific data for monit, which libgtop does not provide.
> 
> I can see your argument for not depending on other libraries (barely),

I totally agree with Christian on this one. monit should run out of
the box and not depend on auxiliary libraries. Ain't you tired of
downloading packages only to find out that you have to install X
libraries, Y other programs and Z pluggins to make it run and then
only getting a core dump because some library was out of sync or you
missed something. 

That said, in my book it is okay chop in the relevant parts from a
third-part library and if necessary build a facade[1] interface
against the sub-system. This is what we have done with our own http
support for monit and to some extent the protocol code.

> but it seems like working within a maintained framework that already
> does a lot of the stuff you need would be more productive (even if you
> keep a private copy of libwhatever in the monit distribution).

I haven't had time to check out libgtop or Christians code, but what
Mark says here makes sense. As I said before libgtop is GPL and we
could do some creative cut-and-paste, and clean up the code in the
process if it's to ugly. 

I know too little about libgtop (anyone have an official url?) but
iff[2] it support, Linux, Solaris and FreeBSD it should be worth
looking at, or what do you think Christian? At least, maybe you will
find out how to do this on FreeBSD and merge the code into your new
codebase.


1. Facade as in the Facade Design Pattern from the GoF book, but I
guess I don't have to tell you guys that :)

2. I vaguely recall from the formal program verification class at the
university, that iff means "if and only if", but that's about all I
can remember from that class :)

-- 
Jan-Henrik Haukeland