[Mldonkey-users] [patch #5360] HTML: Increase webinterface buffer to avoid problems with long output

[z]

Follow-up Comment #24, patch #5360 (project mldonkey):

This patch doesn't make sense to me.  Can someone please explain why it was
added to cvs?

As I understand it, a Buffer is a Buffer.  You can initialize it to 1, or
100000 and it is still a buffer that grows when needed [1]. One specific user
says that it helps, but this doesn't carry much weight since it could be an
illusion just like when people attribute extraneous causes to increased
download speed on a P2P network.

If you don't understand why something happens is it right to apply it to CVS?
 My rational for saying "No": If I can see a bug quickly, I can fix it, but if
you "paper over" or "hide" a bug, I can't experience it as easily and it is
*much* harder to find and fix the real bug.  I don't think increasing the
size at which a Buffer is initialized could possibly fix any "real" bug. 
Does anyone think that it does?  Also, if you don't understand why something
happens, you probably also don't understand the possible consequences of
changing the behaviour of some code (this is more of a general argument for a
lot of patches I've seen go in, not really about this specific patch, but I
had to get it off my chest :-) ).  

Just my 2cents.



[1]
module Buffer: sig .. end
Extensible string buffers. 
This module implements string buffers that automatically expand as necessary.
It provides accumulative concatenation of strings in quasi-linear time
(instead of quadratic time when strings are concatenated pairwise).





    _______________________________________________________

Reply to this item at:

  <http://savannah.nongnu.org/patch/?5360>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.nongnu.org/