[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [MIT-Scheme-devel] Fixes pushed
From: |
craven |
Subject: |
Re: [MIT-Scheme-devel] Fixes pushed |
Date: |
Tue, 01 Mar 2016 07:51:17 +0100 |
User-agent: |
Notmuch/0.21 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-unknown-linux-gnu) |
Hello Chris!
One more, commit 69e6107c introduced optional parameters #!optional
start to vector-fill!, but end was overlooked (even though used in the
function).
I'd suggest the following:
diff --git a/src/runtime/vector.scm b/src/runtime/vector.scm
index 75baafb..90b4319 100644
--- a/src/runtime/vector.scm
+++ b/src/runtime/vector.scm
@@ -68,7 +68,7 @@ USA.
(if (default-object? start) 0 start)
(if (default-object? end) (vector-length vector) end)))
-(define (vector-fill! vector value #!optional start)
+(define (vector-fill! vector value #!optional start end)
(subvector-fill! vector
(if (default-object? start) 0 start)
(if (default-object? end) (vector-length vector) end)
@@ -314,4 +314,4 @@ USA.
(loop (fix:+ i 1))))
#t)))))
Without this, I cannot build current git:
(echo '(with-working-directory-pathname "runtime"' && \
echo ' (lambda () (load "runtime.cbf")))') \
| 'mit-scheme-x86-64' --batch-mode --band ./tools/compiler.com --eval '(begin
)'
;Loading "runtime.cbf"...
; Compiling file: "./advice.bin" => "./advice.com"...
;Unbound variable: end
;To continue, call RESTART with an option number:
; (RESTART 3) => Specify a value to use instead of end.
; (RESTART 2) => Define end to a given value.
; (RESTART 1) => Return to read-eval-print level 1.
Greetings,
Peter
- Re: [MIT-Scheme-devel] Fixes pushed,
craven <=