Re: [MIT-Scheme-devel] [commit f372dae] Don't call OS_free_pages after GC flip. We don't resize the heap and we will be reusing it.

[Taylor R Campbell]

   commit f372dae7d971166dc4a66955ea40e54e7ab04cb4
   Author: Joe Marshall <address@hidden>
   Date:   Thu Sep 22 11:51:25 2011 -0700

    Don't call OS_free_pages after GC flip.  We don't resize the heap and we 
will be reusing it.

   --- a/src/microcode/memmag.c
   +++ b/src/microcode/memmag.c
   @@ -326,7 +326,6 @@ void
    std_gc_pt2 (void)
    {
      SCHEME_OBJECT * p = (get_newspace_ptr ());
   -  OS_free_pages (heap_start, heap_end);
      (void) save_tospace (save_tospace_copy, 0);
      Free = p;
 
Maybe the intent of OS_free_pages wasn't clear, but while we will be
reusing those pages of virtual memory, we won't be reusing the data
that we had stored in them.  I added that in order to significantly
reduce Scheme's physical memory usage.  Did you observe a problem
whose source you isolated to the use of OS_free_pages?