Re: [Mingw-cross-env-list] libvpx fails to build with "local: build/: bad variable name"

[Volker Grabsch]

Martin Lambers schrieb:
> On Sun, 12 Feb 2012 12:48:24 +1100, Tony Theodore wrote:
> > On 12 February 2012 00:29, Simon A. Eugster <address@hidden> wrote:
> > > I could build qt4 and gcc, which I'm very glad about, but ffmpeg
> > > does not want to be built yet. What is the problem here?
> > 
> > It seems you're on a system where /bin/sh isn't bash. If you have a
> > /bin/bash, you can delete the two libvpx-*.patch files for the time
> > being.
> 
> I have the same problem.
> 
> Wouldn't it be better to change libvpx-2-fix-bin-bash.patch to replace
> '#!/bin/bash' with '#!/usr/bin/env bash' instead of '#!/bin/sh'? That's
> the standard way to run a script with bash if the location of bash is
> unknown but in PATH (e.g. on the BSDs).

I fully agree. If a script starts with "#!/bin/bash" it almost certainly
contains bashisms, so it should be adjusted to "#!/usr/bin/env bash".

Changing it to "#!/bin/sh" would have made only make sense if the script
didn't contain any bashisms for sure.

I just fixed this in the stable and default branch:
http://hg.savannah.gnu.org/hgweb/mingw-cross-env/rev/94b091de1507


Greets,
Volker

-- 
Volker Grabsch
---<<(())>>---