Re: [Mingw-cross-env-list] [PATCH] libgsasl: disable nls, add test program

[Martin Lambers]

Hi Mark!

On 27/04/11 17:07, Mark Brand wrote:
> On 04/27/2011 03:24 PM, Martin Lambers wrote:
>> the attached patch explicitly disables NLS in libgsasl, as is done with
>> other packages already. Without this patch, libgsasl drags in a
>> dependency on libintl if gettext happens to be built before libgsasl.
>>
>> Also, the patch adds a minimal test program.
> 
> Thanks. Committed:
> 
> http://hg.savannah.gnu.org/hgweb/mingw-cross-env/rev/59bbe6b0dcc2
> 
> Your test program makes it clear that libgcrypt is needed, so I fixed
> libgsasl's .pc file and dependencies.
> 
> http://hg.savannah.gnu.org/hgweb/mingw-cross-env/rev/ef3ecfdc6c1e
> 
> How did that work for you without libgcrypt?

Libgsasl uses gnulib for crypto functions such as MD5 and SHA1. Gnulib,
in turn, can either use libgcrypt if available, or use builtin code.
So libgsasl does work without libgcrypt when the configure script does
not detect it.

So we need to either explicitly depend on it (like your patch does), or
explicitly disable it. I think explicitly depending on it is the right
choice.

Martin