Re: [Mingw-cross-env-list] SDL and zziplib patches

[Volker Grabsch]

Gregory Smith <address@hidden> schrieb:
> I don't know what the criteria are you use to decide whether to accept
> patches, but I thought I'd submit these since I find them necessary
> locally.

Thanks for the contribution!

> The first, sdl-fix-dinput.patch, is necessary or SDL can crash at
> startup using the directx5 driver. It was accepted into SDL HG:
> http://hg.libsdl.org/SDL/diff/daf9e6037596/src/video/windx5/SDL_dx5events.c

Okay, and thanks for the link.

> The second, zziplib.mk.patch, should be applied to zziplib.mk. It adds
> --disable-mmap, because for whatever reason, mingw's mmap crashes when
> you try to use it. This is necessary for any program that uses zziplib
> to work.

This patch also contains the following change:

    -    cd '$(1)' && ./configure \
    +    cd '$(1)' && aclocal && ./configure \

What is that good for? Why do you call "aclocal"? Is there a good
reason for that, or is it just some leftover from debugging?

> The third, zziplib-fix-fnmatch.patch, allows zziplib to build without
> mmap. I am not certain I submitted it to upstream, and it's not in
> their revision control. It's just a missing header include.

If you really didn't submit it to upstream, please do that.
Is there any mailing list entry or bugtracking entry we could
link to? If so, what's the URL?


Greets,

    Volker

-- 
Volker Grabsch
---<<(())>>---
Administrator
NotJustHosting GbR