[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Mingw-cross-env-list] [PATCH] Add OpenSceneGraph
From: |
Martin Lambers |
Subject: |
Re: [Mingw-cross-env-list] [PATCH] Add OpenSceneGraph |
Date: |
Thu, 21 Jan 2010 22:08:11 +0100 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Thu, 21. Jan 2010, 01:51:29 +0100, Volker Grabsch wrote:
> > I forced cmake to use the correct pkg-config binary with
> > '-DPKG_CONFIG_EXECUTABLE=$(PREFIX)/bin/$(TARGET)-pkg-config'.
>
> 1) Does this still work when you simplify this line to:
>
> -DPKG_CONFIG_EXECUTABLE=$(TARGET)-pkg-config
>
> ?
Yes it does. Corrected in the attached patch.
> 2) Please don't use <TAB> characters for alignment.
I agree, it was unintentional.
> > We cannot hide the fact that static
> > OSG is used anyway, so let's not make the behaviour on mingw-cross-env
> > different from the behaviour on other platforms.
>
> That's a valid point. So I agree that we don't need it for
> OSG, but let's take libraries like OSG and Qt as exceptions,
> not as the norm.
I'm still not convinced, but since adding this to pkgconfig does not
break the build rule "if you want static OSG, add -DOSG_LIBRARY_STATIC
yourself", I don't care strongly about it.
Martin
osg.patch
Description: Text Data
- Re: [Mingw-cross-env-list] [PATCH] Add OpenSceneGraph, (continued)
- Re: [Mingw-cross-env-list] [PATCH] Add OpenSceneGraph, Volker Grabsch, 2010/01/13
- Re: [Mingw-cross-env-list] [PATCH] Add OpenSceneGraph, Martin Lambers, 2010/01/13
- Re: [Mingw-cross-env-list] [PATCH] Add OpenSceneGraph, Volker Grabsch, 2010/01/13
- Re: [Mingw-cross-env-list] [PATCH] Add OpenSceneGraph, Volker Grabsch, 2010/01/16
- Re: [Mingw-cross-env-list] [PATCH] Add OpenSceneGraph, Martin Lambers, 2010/01/16
- Re: [Mingw-cross-env-list] [PATCH] Add OpenSceneGraph, Martin Lambers, 2010/01/17
- Re: [Mingw-cross-env-list] [PATCH] Add OpenSceneGraph, Volker Grabsch, 2010/01/19
- Re: [Mingw-cross-env-list] [PATCH] Add OpenSceneGraph, Martin Lambers, 2010/01/20
- Re: [Mingw-cross-env-list] [PATCH] Add OpenSceneGraph, Martin Lambers, 2010/01/20
- Re: [Mingw-cross-env-list] [PATCH] Add OpenSceneGraph, Volker Grabsch, 2010/01/20
- Re: [Mingw-cross-env-list] [PATCH] Add OpenSceneGraph,
Martin Lambers <=
- Re: [Mingw-cross-env-list] [PATCH] Add OpenSceneGraph, Volker Grabsch, 2010/01/21
- Re: [Mingw-cross-env-list] [PATCH] Add OpenSceneGraph, Volker Grabsch, 2010/01/21
- Re: [Mingw-cross-env-list] [PATCH] Add OpenSceneGraph, Martin Lambers, 2010/01/22
- Re: [Mingw-cross-env-list] [PATCH] Add OpenSceneGraph, Volker Grabsch, 2010/01/22
- Re: [Mingw-cross-env-list] [PATCH] Add OpenSceneGraph, Martin Lambers, 2010/01/26
- Re: [Mingw-cross-env-list] [PATCH] Add OpenSceneGraph, Martin Lambers, 2010/01/26
- Re: [Mingw-cross-env-list] [PATCH] Add OpenSceneGraph, Volker Grabsch, 2010/01/26