[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Minor patch to correct buffer overrun

From: Paul Smith
Subject: Re: Minor patch to correct buffer overrun
Date: Mon, 16 Aug 2010 09:32:51 -0400

On Mon, 2010-08-16 at 09:17 -0400, Chris Sutcliffe wrote:
> As reported on the MinGW-Users mailing list, there is an issue with
> buffer overrun regarding 'MAXPATHLEN'.  MinGW's sys/param.h defines
> 'MAXPATHLEN' as follows:
> where 'PATH_MAX' is 259.  The issue is that make expects 'MAXPATHLEN'
> to be considerably bigger (1024).

Hi Chris; thanks for the patch.  I'm not a Windows person so I'm not
exactly sure where the problem lies.

Are you saying that MinGW defines a MAXPATHLEN that is shorter than the
real maximum path length on Windows, and that the max path length on
Windows is really 1024 not 259?  So, this change is a workaround for a
MinGW system header bug?

Or, are you saying that make is using this value incorrectly, and that
instead of MAXPATHLEN it should be using something else?

And, I'm not sure what you mean by "make expects 'MAXPATHLEN' to be
considerably bigger"; in what way does make expect this?  Do you mean
that in one place make creates a buffer of 1024, and in another place it
tries to copy it into a buffer that is MAXPATHLEN large?

It would greatly help us if you could explain the bug in more detail,
including the symptoms, in addition to providing a patch to fix it.

Thanks again!

 Paul D. Smith <address@hidden>          Find some GNU make tips at:            
 "Please remain calm...I may be mad, but I am a professional." --Mad Scientist

reply via email to

[Prev in Thread] Current Thread [Next in Thread]