[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: GNU make 3.81rc1 released -- please test.
From: |
Eli Zaretskii |
Subject: |
Re: GNU make 3.81rc1 released -- please test. |
Date: |
Fri, 24 Feb 2006 20:42:07 +0200 |
> From: "J. David Bryan" <address@hidden>
> Date: Fri, 24 Feb 2006 13:06:28 -0500
> CC: address@hidden, address@hidden
>
> > + if (just_print_flag) {
> > + /* Need to allocate new_argv, although it's unused, because
> > + start_job_command will want to free it and its 0'th element. */
> > + new_argv = (char **) xmalloc(2 * sizeof (char *));
> > + new_argv[0] = xstrdup ("");
> > + new_argv[1] = NULL;
> > + }
> > if ((no_default_sh_exe || batch_mode_shell) && batch_filename_ptr) {
> > int temp_fd;
> > FILE* batch = NULL;
>
> I believe that the "if ((no_default_sh_exe..." statement following your
> changed lines should be an "else if"
Yes, it should--but that looks like some snafu when my previous patch
was applied, because there it was "else if".
Paul?