[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Make CVS (Win32) improperly leaves batch files with -n

From: J. David Bryan
Subject: Make CVS (Win32) improperly leaves batch files with -n
Date: Mon, 13 Feb 2006 19:55:22 -0500

Running the current CVS version under Windows with the "-n" (--dry-run) 
option against the following example makefile:

        @echo hello
        @echo there

...will leave two batch files in the TEMP directory each time it is run.  
Running without -n properly cleans up the files.

The problem appears to be that "construct_command_argv_internal" (job.c, 
lines 2769 and on) creates and writes batch files for shell commands 
regardless of the "-n" option.  However, with "-n", the shell is never 
invoked, and so the batch files are never cleaned up on process 
termination.  Note that this is not a recent regression; make-3.80 exhibits 
the same problem.

Should batch file creation be conditional on the "just_print_flag" value?

Related to this, could someone kindly explain why the above sample commands 
are passed via batch files at all, instead of by invoking "cmd /c echo 
hello" directly?

                                      -- Dave

reply via email to

[Prev in Thread] Current Thread [Next in Thread]