[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: mingw fails to build with latest update
From: |
Antonio Diaz Diaz |
Subject: |
Re: mingw fails to build with latest update |
Date: |
Thu, 29 Feb 2024 17:56:21 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i586; en-US; rv:1.9.1.19) Gecko/20110420 SeaMonkey/2.0.14 |
Hi Sean,
Sean Link wrote:
See https://github.com/NixOS/nixpkgs/pull/292137
Thanks.
As reported at
https://github.com/NixOS/nixpkgs/pull/292137#issuecomment-1970071254 , the
problem is already (hopefully) fixed upstream.
It is a pity that nobody cares to test the release candidates (I released at
least one RC for each tool in the lzip family that includes the mkdir
change, 2 for lzip[1]).
I'll release lzip-1.24.1 with the following patch applied as soon as I
receive confirmation that it fixes the compilation problen on mingw:
--- lzip-1.24/main.cc 2024-01-26 00:08:47.000000000 +0100
+++ lzip-1.24.1/src/main.cc 2024-02-06 16:04:00.000000000 +0100
@@ -42,8 +42,10 @@
#if defined __MSVCRT__ || defined __OS2__ || defined __DJGPP__
#include <io.h>
#if defined __MSVCRT__
+#include <direct.h>
#define fchmod(x,y) 0
#define fchown(x,y,z) 0
+#define mkdir(name,mode) _mkdir(name)
#define strtoull std::strtoul
#define SIGHUP SIGTERM
#define S_ISSOCK(x) 0
[1] http://download.savannah.gnu.org/releases/lzip/lzip-1.24-rc1.tar.lz
http://download.savannah.gnu.org/releases/lzip/lzip-1.24-rc2.tar.lz
Best regards,
Antonio.