Re: [Lzip-bug] lzlib-1.5

[Antonio Diaz Diaz]

Hello,

Guozhi Tao wrote:
> We are trying to use the lzlib-1.5 during our work. From your original source 
> code, I had trouble to build on windows. So I made a few changes

I thought lzlib already compiled on windows[1], but I do not use 
windows, so I don't know for sure. OTOH, windows seems to be a difficult 
target because every compiler seems to define its own feature macros[2].

[1] http://lists.nongnu.org/archive/html/lzip-bug/2009-10/msg00036.html
[2] http://lists.nongnu.org/archive/html/lzip-bug/2014-03/msg00004.html

> 1, add a .def file to export dll in windows.
> 2, add a few #include in several files.
> 3, add #ifdef or #ifndef _WIN32 to for windows use.
> 4, wrote a cmake file for cross platform build.
>
> Now I can build your code in both windows and unix.  Do you need us to send 
> your the new code for crossplatform build? If you have any request, please let 
> me know.

Please, send it. It does not hurt to see new ideas. :-) But keep in mind 
that making everyone happy may be impossible. For example, using 
"_WIN32" may break cygwin builds[3].

[3] http://lists.nongnu.org/archive/html/lzip-bug/2010-08/msg00016.html


Best regards,
Antonio.