Re: [Lzip-bug] make check of lzip 1.8 fails on Fedora Rawhide targetting F13

[Ersek, Laszlo]

On Thu, 31 Dec 2009, Till Maas wrote:

> I wanted to build lzip 1.8 on Fedora, but it fails in make check with:
>
> | + make check
> | testing lzip...in copy differ: char 1, line 1
> | ...........................................
> | tests failed.
>
> A full build log is available here:
> http://koji.fedoraproject.org/koji/getfile?taskID=1896651&name=build.log
>
> It fails for both i386 and x86_64.

I think it is a problem with your build system.

The section that fails in "lzip-1.8/testsuite/check.sh" is probably this:

    23  echo -n "testing lzip..."
    24  cd "${objdir}"/tmp
    25
    26  cat "${testdir}"/../COPYING > in || framework_failure
    27  fail=0
    28
    29  "${LZIP}" -cd "${testdir}"/COPYING.lz > copy || fail=1
    30  cmp in copy || fail=1

based on the following segment of your log:

    116 testing lzip...in copy differ: char 1, line 1

The test case in question decompresses the prepackaged "COPYING.lz" file 
and compares the result to the (also prepackaged) "COPYING" file (residing 
one directory higher up). However, your log contains

     30 + sed -i 's/\r//' COPYING

which removes the first CR character in each line of "COPYING". Checking 
the prepackaged "COPYING" file:

----v----
$ head -n 3 COPYING | hexdump -C

00000000  0d 0a 09 09 20 20 20 20  47 4e 55 20 47 45 4e 45  |....    GNU GENE|
00000010  52 41 4c 20 50 55 42 4c  49 43 20 4c 49 43 45 4e  |RAL PUBLIC LICEN|
00000020  53 45 0d 0a 09 09 20 20  20 20 20 20 20 56 65 72  |SE....       Ver|
00000030  73 69 6f 6e 20 33 2c 20  32 39 20 4a 75 6e 65 20  |sion 3, 29 June |
00000040  32 30 30 37 0d 0a                                 |2007..|
00000046

$ file COPYING

COPYING: ASCII English text, with CRLF line terminators
----^----

reveals that, in fact, the sed command modified the first byte of the 
prepackaged "COPYING" file.

Cheers,
lacos