Re: lynx-dev [PATCH] "change directory" command

[Ismael Cordeiro]

On Mon, 17 Jul 2000, Vlad Harchev wrote:

> > It seems that Thomas is right, your patch broke something. In the prompt
> > "D)ownload, or C)ancel" the "c" and "C" commands don't work anymore.
> > Commenting out "#define "SUPPORT_CHDIR" in userdefs.h, as suggested in
> > the CHANGES file, doesn't re-enable the commands above.
> 
>  It's not my patch's failure - Tom overlooked something in HTFWriter.c, the
> fix for this attached.

Anyway, your patch fixed it and the problem was corrected in dev.5/dev.6.

> > By the way, I think that it would be better to make clear that what the
> > command does is to change the _current_ directory by calling it "change
> > current directory" everywhere and by changing SUPPORT_CHDIR to something
> > like SUPPORT_CHCURDIR.
> 
>   I don't think that is right idea - what directory "change directory"
>  command could change beside current?

Well, even you used "current directory" in your patch:

| +#KEYMAP:C:CHDIR              # Change current directory

+ { "CHDIR",            "change current directory" },

That's why I said to change it _everywhere_. 

Actually, "current directory" is not a good name for it. The current
directory is the one I'm on in a certain moment (in DIRED). I could have gone
there with "g" or following links in DIRED. That "current directory" is the
directory where you have run lynx from, the one you can (g)o to with "." and
the one where files will be saved by default. What would be a good name for
it? "default directory"? "base directory"? ". directory"? "original
directory"? Any other ideas?

Another confusing thing is the text in userdefs.h: 

| + * SUPPORT_CHDIR provides CD command (bound to 'C' by default). It allows
| + * changing directory to arbitrary location (if OS allows them). If dired
| + * is enabled, user will be able to visit any directory and view any file
| + * allowed accroding to file permissions or ACLs.

To do that one doesn't need the "C" command. One can use the "g" command or
follow links in DIRED "to visit any directory and view any file allowed
accroding to file permissions or ACLs."

>  Thanks for evaluating dev4. Seems nobody else uses it (probably Eduardo
> uses it too).

I'm always using the latest version and I believe that many do the same. It's
just that we're not finding many bugs... :-)

Thank you.

Ismael
-- 
       ________________________________________________________________
      |                                                                |
      | ISMAEL CORDEIRO            | mailto:address@hidden        |
      | Production sound mixer     | http://www.pubnix.net/~ismael/    |
      | Montréal - Québec - Canada | ftp://ftp.pubnix.net/users/ismael |
      |________________________________________________________________|


; To UNSUBSCRIBE: Send "unsubscribe lynx-dev" to address@hidden